Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-05-15 Thread Wei Yang
On Wed, May 15, 2019 at 10:38:37AM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> On Wed, May 15, 2019 at 02:38:27PM +0800, Wei Yang wrote: >> >On Tue, May 14, 2019 at 04:18:14PM +0100, Dr. David Alan Gilbert wrote: >> >>* Wei Yang (richardw.y...@linux.in

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-05-15 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > On Wed, May 15, 2019 at 02:38:27PM +0800, Wei Yang wrote: > >On Tue, May 14, 2019 at 04:18:14PM +0100, Dr. David Alan Gilbert wrote: > >>* Wei Yang (richardw.y...@linux.intel.com) wrote: > >>> > >>> Well, when you look into the source side of mig

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-05-15 Thread Wei Yang
On Wed, May 15, 2019 at 02:38:27PM +0800, Wei Yang wrote: >On Tue, May 14, 2019 at 04:18:14PM +0100, Dr. David Alan Gilbert wrote: >>* Wei Yang (richardw.y...@linux.intel.com) wrote: >>> >>> Well, when you look into the source side of migration: >>> >>> qmp_migrate >>> migrate_prepare >>> m

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-05-14 Thread Wei Yang
On Tue, May 14, 2019 at 04:18:14PM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> >> Well, when you look into the source side of migration: >> >> qmp_migrate >> migrate_prepare >> migration_is_blocked >> >> This means if migration_is_blocked fail

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-05-14 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > On Thu, Apr 25, 2019 at 05:55:15PM -0300, Daniel Henrique Barboza wrote: > > > > > >On 4/23/19 9:46 PM, Wei Yang wrote: > >> migration_is_blocked() is used in migrate_prepare() and > >> save_snapshot(), this is more proper to use this instead of >

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-04-25 Thread Wei Yang
On Thu, Apr 25, 2019 at 05:55:15PM -0300, Daniel Henrique Barboza wrote: > > >On 4/23/19 9:46 PM, Wei Yang wrote: >> migration_is_blocked() is used in migrate_prepare() and >> save_snapshot(), this is more proper to use this instead of >> qemu_savevm_state_blocked() in qemu_loadvm_state(). > > >mig

Re: [Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-04-25 Thread Daniel Henrique Barboza
On 4/23/19 9:46 PM, Wei Yang wrote: migration_is_blocked() is used in migrate_prepare() and save_snapshot(), this is more proper to use this instead of qemu_savevm_state_blocked() in qemu_loadvm_state(). migration_is_blocked() does an additional verification: "if (migration_blockers)" com

[Qemu-devel] [PATCH 2/4] migration/savevm: use migration_is_blocked to validate

2019-04-23 Thread Wei Yang
migration_is_blocked() is used in migrate_prepare() and save_snapshot(), this is more proper to use this instead of qemu_savevm_state_blocked() in qemu_loadvm_state(). Signed-off-by: Wei Yang --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/sav