Re: [Qemu-devel] [PATCH 2/4] hw: Propagate errors through qdev_prop_set_drive()

2015-02-21 Thread Peter Crosthwaite
On Fri, Feb 20, 2015 at 11:19 AM, Markus Armbruster wrote: > Three kinds of callers: > > 1. On failure, report the error and abort > >Passing &error_abort does the job. No functional change. > > 2. On failure, report the error and exit() > >This is qdev_prop_set_drive_nofail(). Error rep

[Qemu-devel] [PATCH 2/4] hw: Propagate errors through qdev_prop_set_drive()

2015-02-20 Thread Markus Armbruster
Three kinds of callers: 1. On failure, report the error and abort Passing &error_abort does the job. No functional change. 2. On failure, report the error and exit() This is qdev_prop_set_drive_nofail(). Error reporting moves from qdev_prop_set_drive() to its caller. Because hiding