Re: [Qemu-devel] [PATCH 2/4] block/rbd: code movement

2017-02-27 Thread Jeff Cody
On Mon, Feb 27, 2017 at 09:28:56AM +, Daniel P. Berrange wrote: > > Describing this as "code movement" when the added & removed chunks are not > identical is a bit misleading. > > Can you expand the commit message to explain why the extra options are > being added Ah, sorry - yes. The lack

Re: [Qemu-devel] [PATCH 2/4] block/rbd: code movement

2017-02-27 Thread Daniel P. Berrange
Describing this as "code movement" when the added & removed chunks are not identical is a bit misleading. Can you expand the commit message to explain why the extra options are being added On Mon, Feb 27, 2017 at 02:30:39AM -0500, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > block/rbd.c

[Qemu-devel] [PATCH 2/4] block/rbd: code movement

2017-02-26 Thread Jeff Cody
Signed-off-by: Jeff Cody --- block/rbd.c | 64 +++-- 1 file changed, 45 insertions(+), 19 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 3f1a9de..c8d4eb1 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -357,6 +357,51 @@ static void