Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-13 Thread David Gibson
On Tue, Mar 13, 2012 at 10:57:37AM +0100, Gerd Hoffmann wrote: > On 03/13/12 05:22, Benjamin Herrenschmidt wrote: > > As such I would rather fix the access locations instead. This basically > > means adding this small patch on top of my previous one (I haven't > > spotted any other error) : > > Sq

Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-13 Thread Benjamin Herrenschmidt
On Tue, 2012-03-13 at 10:57 +0100, Gerd Hoffmann wrote: > On 03/13/12 05:22, Benjamin Herrenschmidt wrote: > > As such I would rather fix the access locations instead. This basically > > means adding this small patch on top of my previous one (I haven't > > spotted any other error) : > > Squashed

Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-13 Thread Gerd Hoffmann
On 03/13/12 05:22, Benjamin Herrenschmidt wrote: > As such I would rather fix the access locations instead. This basically > means adding this small patch on top of my previous one (I haven't > spotted any other error) : Squashed into the original patch and added to the usb patch queue. cheers,

Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-12 Thread Benjamin Herrenschmidt
On Fri, 2012-03-09 at 13:46 +0100, Gerd Hoffmann wrote: > On 03/08/12 01:41, David Gibson wrote: > > From: Benjamin Herrenschmidt > > > -assert(s->csw.sig == 0x53425355); > > +assert(s->csw.sig == cpu_to_le32(0x53425355)); > > Correct but incomplete. residue is sent in host endian inste

Re: [Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-09 Thread Gerd Hoffmann
On 03/08/12 01:41, David Gibson wrote: > From: Benjamin Herrenschmidt > -assert(s->csw.sig == 0x53425355); > +assert(s->csw.sig == cpu_to_le32(0x53425355)); Correct but incomplete. residue is sent in host endian instead of little endian too. It is zero most of the time though, so it ea

[Qemu-devel] [PATCH 2/4] Endian fix an assertion in usb-msd

2012-03-07 Thread David Gibson
From: Benjamin Herrenschmidt This fixes a broken endian assumption in an assertion in usb-msd. Cc: Gerd Hoffman Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- hw/usb-msd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-