Re: [Qemu-devel] [PATCH 2/3] xhci: remove unused code

2015-05-05 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH 2/3] xhci: remove unused code

2015-05-05 Thread Gerd Hoffmann
Hi, > > So, I think if we were to drop this assignment, we should > > remove the initializer too. But before doing this, I think > > we should try to remember _why_ this assignment is here in > > the first place. The code looks like after the loop, this > > ep variable was supposed to be used

Re: [Qemu-devel] [PATCH 2/3] xhci: remove unused code

2015-04-29 Thread Gonglei
On 2015/4/29 14:48, Michael Tokarev wrote: > 28.04.2015 12:11, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> Value from xfer->packet.ep is assigned to ep here, but that >> stored value is not used before it is overwritten. Remove it. >> >> Cc: Gerd Hoffmann >> Signed-off-by: Gonglei >> -

Re: [Qemu-devel] [PATCH 2/3] xhci: remove unused code

2015-04-28 Thread Michael Tokarev
28.04.2015 12:11, arei.gong...@huawei.com wrote: > From: Gonglei > > Value from xfer->packet.ep is assigned to ep here, but that > stored value is not used before it is overwritten. Remove it. > > Cc: Gerd Hoffmann > Signed-off-by: Gonglei > --- > hw/usb/hcd-xhci.c | 1 - > 1 file changed, 1

[Qemu-devel] [PATCH 2/3] xhci: remove unused code

2015-04-28 Thread arei.gonglei
From: Gonglei Value from xfer->packet.ep is assigned to ep here, but that stored value is not used before it is overwritten. Remove it. Cc: Gerd Hoffmann Signed-off-by: Gonglei --- hw/usb/hcd-xhci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index