[Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-21 Thread Tim Hardeck
This patch adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option "websocket"is

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-11 Thread Tim Hardeck
On 01/08/2013 01:38 AM, Anthony Liguori wrote: > Better, but I still think it's better to advance the buffer based on the > parsed header sizes that to assume there's no additional data. I have used buffer_advance in the patch set v6. Does anything else need to be changed? Regards Tim -- SUSE L

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-09 Thread Blue Swirl
On Tue, Jan 8, 2013 at 10:27 AM, Tim Hardeck wrote: > This patch adds basic Websocket Protocol version 13 - RFC 6455 - support > to QEMU VNC. Binary encoding support on the client side is mandatory. > > Because of the GnuTLS requirement the Websockets implementation is > optional (--enable-vnc-ws)

[Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-08 Thread Tim Hardeck
This patch adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option "websocket"is

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-07 Thread Anthony Liguori
Tim Hardeck writes: > Hi Anthony, > > thanks for your feedback. > > On Mon, 2013-01-07 at 13:52 -0600, Anthony Liguori wrote: >> Tim Hardeck writes: > > +void vncws_handshake_read(void *opaque) >> > +{ >> > +VncState *vs = opaque; >> > +long ret; >> > +buffer_reserve(&vs->ws_input, 4

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-07 Thread Tim Hardeck
Hi Anthony, thanks for your feedback. On Mon, 2013-01-07 at 13:52 -0600, Anthony Liguori wrote: > Tim Hardeck writes: > > +void vncws_handshake_read(void *opaque) > > +{ > > +VncState *vs = opaque; > > +long ret; > > +buffer_reserve(&vs->ws_input, 4096); > > +ret = vnc_client_rea

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-07 Thread Anthony Liguori
Tim Hardeck writes: > This patch adds basic Websocket Protocol version 13 - RFC 6455 - support > to QEMU VNC. Binary encoding support on the client side is mandatory. > > Because of the GnuTLS requirement the Websockets implementation is > optional (--enable-vnc-ws). > > To activate Websocket sup

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-05 Thread Tim Hardeck
Hi, thanks for your suggestions. On Fri, 2013-01-04 at 20:20 +, Blue Swirl wrote: > On Wed, Jan 2, 2013 at 1:29 PM, Tim Hardeck wrote: > > + * We are working around a bug present in GCC < 4.6 which prevented > > + * it from recognizing anonymous structs and unions. > > + * See

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-04 Thread Blue Swirl
On Wed, Jan 2, 2013 at 1:29 PM, Tim Hardeck wrote: > This patch adds basic Websocket Protocol version 13 - RFC 6455 - support > to QEMU VNC. Binary encoding support on the client side is mandatory. > > Because of the GnuTLS requirement the Websockets implementation is > optional (--enable-vnc-ws).

[Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-02 Thread Tim Hardeck
This patch adds basic Websocket Protocol version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is mandatory. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). To activate Websocket support the VNC option "websocket"is