Re: [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

2013-04-24 Thread Lei Li
On 04/24/2013 07:44 PM, Gerd Hoffmann wrote: Hi, +case VNC_ENCODING_LED_STATE: +vs->features |= VNC_FEATURE_LED_STATE_MASK; +break; I think it with the client supporting the led state extension it is probably a good idea to turn off the lock state sync logic

Re: [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

2013-04-24 Thread Gerd Hoffmann
Hi, > +case VNC_ENCODING_LED_STATE: > +vs->features |= VNC_FEATURE_LED_STATE_MASK; > +break; I think it with the client supporting the led state extension it is probably a good idea to turn off the lock state sync logic in qemu's vnc server, i.e. add a "!(vs->fea

[Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

2013-04-24 Thread Lei Li
Signed-off-by: Lei Li --- ui/vnc.c | 45 + ui/vnc.h |4 +++- 2 files changed, 48 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index f574962..44189d7 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1522,6 +1522,42 @@ static void press_k

Re: [Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

2013-04-22 Thread Anthony Liguori
Lei Li writes: > Signed-off-by: Lei Li > --- > ui/vnc.c | 48 > ui/vnc.h |4 +++- > 2 files changed, 51 insertions(+), 1 deletions(-) > > diff --git a/ui/vnc.c b/ui/vnc.c > index f574962..e22cca1 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @

[Qemu-devel] [PATCH 2/3] vnc: Support for LED state extension

2013-04-19 Thread Lei Li
Signed-off-by: Lei Li --- ui/vnc.c | 48 ui/vnc.h |4 +++- 2 files changed, 51 insertions(+), 1 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index f574962..e22cca1 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1522,6 +1522,45 @@ static void pres