Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-12 Thread Andrew Jones
On Tue, Nov 11, 2014 at 04:31:24PM -0200, Eduardo Habkost wrote: > On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: > [...] > > Below is a v2 I can post if it looks good to you. > > > > From: Andrew Jones > > Date: Fri, 7 Nov 2014 15:45:07 +0100 > > Subject: [PATCH v2] vl: sanity che

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Eduardo Habkost
On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: [...] > Below is a v2 I can post if it looks good to you. > > From: Andrew Jones > Date: Fri, 7 Nov 2014 15:45:07 +0100 > Subject: [PATCH v2] vl: sanity check cpu topology > > smp_parse allows partial or complete cpu topology to be gi

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Eduardo Habkost
On Tue, Nov 11, 2014 at 06:04:18PM +0100, Andrew Jones wrote: > On Tue, Nov 11, 2014 at 01:48:00PM -0200, Eduardo Habkost wrote: > > On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: > > > On Tue, Nov 11, 2014 at 10:41:00AM -0200, Eduardo Habkost wrote: > > > > On Fri, Nov 07, 2014 at 0

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Andrew Jones
On Tue, Nov 11, 2014 at 01:48:00PM -0200, Eduardo Habkost wrote: > On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: > > On Tue, Nov 11, 2014 at 10:41:00AM -0200, Eduardo Habkost wrote: > > > On Fri, Nov 07, 2014 at 05:04:39PM +0100, Andrew Jones wrote: > > > > smp_parse allows partial

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Eduardo Habkost
On Tue, Nov 11, 2014 at 03:37:11PM +0100, Andrew Jones wrote: > On Tue, Nov 11, 2014 at 10:41:00AM -0200, Eduardo Habkost wrote: > > On Fri, Nov 07, 2014 at 05:04:39PM +0100, Andrew Jones wrote: > > > smp_parse allows partial or complete cpu topology to be given. > > > In either case there may be i

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Andrew Jones
On Tue, Nov 11, 2014 at 10:41:00AM -0200, Eduardo Habkost wrote: > On Fri, Nov 07, 2014 at 05:04:39PM +0100, Andrew Jones wrote: > > smp_parse allows partial or complete cpu topology to be given. > > In either case there may be inconsistencies in the input which > > are currently not sounding any a

Re: [Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-11 Thread Eduardo Habkost
On Fri, Nov 07, 2014 at 05:04:39PM +0100, Andrew Jones wrote: > smp_parse allows partial or complete cpu topology to be given. > In either case there may be inconsistencies in the input which > are currently not sounding any alarms. In some cases the input > is even being silently corrected. We sho

[Qemu-devel] [PATCH 2/3] vl: sanity check cpu topology

2014-11-07 Thread Andrew Jones
smp_parse allows partial or complete cpu topology to be given. In either case there may be inconsistencies in the input which are currently not sounding any alarms. In some cases the input is even being silently corrected. We shouldn't do this. Add warnings when input isn't adding up right, and eve