Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-18 Thread Paolo Bonzini
- Original Message - > From: "Michael S. Tsirkin" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "alex williamson" , > borntrae...@de.ibm.com, fel...@nutanix.com > Sent: Thursday, November 17, 2016 11:33:24 PM > Subject: Re: [PATCH 2/3] virtio: access ISR atomically > > On Thu, No

Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-17 Thread Michael S. Tsirkin
On Thu, Nov 17, 2016 at 02:49:58PM -0500, Paolo Bonzini wrote: > > > - Original Message - > > From: "Michael S. Tsirkin" > > To: "Paolo Bonzini" > > Cc: qemu-devel@nongnu.org, "alex williamson" , > > borntrae...@de.ibm.com, fel...@nutanix.com > > Sent: Thursday, November 17, 2016 6:55:

Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-17 Thread Paolo Bonzini
- Original Message - > From: "Michael S. Tsirkin" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "alex williamson" , > borntrae...@de.ibm.com, fel...@nutanix.com > Sent: Thursday, November 17, 2016 6:55:50 PM > Subject: Re: [PATCH 2/3] virtio: access ISR atomically > > On Wed, Nov

Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-17 Thread Michael S. Tsirkin
On Wed, Nov 16, 2016 at 07:05:50PM +0100, Paolo Bonzini wrote: > @@ -1318,10 +1318,18 @@ void virtio_del_queue(VirtIODevice *vdev, int n) > vdev->vq[n].vring.num_default = 0; > } > > +static void virtio_set_isr(VirtIODevice *vdev, int value) > +{ > +uint8_t old = atomic_read(&vdev->isr)

[Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-16 Thread Paolo Bonzini
This will be needed once dataplane will be able to set it outside the big QEMU lock. Signed-off-by: Paolo Bonzini --- v1->v2: squash syntax error fix from patch 3 [Christian] hw/virtio/virtio-mmio.c | 6 +++--- hw/virtio/virtio-pci.c | 9 +++-- hw/virtio/virtio.c | 18 ++

Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-15 Thread Paolo Bonzini
On 15/11/2016 16:03, Christian Borntraeger wrote: > On 11/15/2016 02:46 PM, Paolo Bonzini wrote: >> This will be needed once dataplane will be able to set it outside >> the big QEMU lock. >> >> Signed-off-by: Paolo Bonzini > > This is fixed by the followup patch, but this patch alone gives me >

Re: [Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-15 Thread Christian Borntraeger
On 11/15/2016 02:46 PM, Paolo Bonzini wrote: > This will be needed once dataplane will be able to set it outside > the big QEMU lock. > > Signed-off-by: Paolo Bonzini This is fixed by the followup patch, but this patch alone gives me /home/cborntra/REPOS/qemu/hw/virtio/virtio.c: In function ‘v

[Qemu-devel] [PATCH 2/3] virtio: access ISR atomically

2016-11-15 Thread Paolo Bonzini
This will be needed once dataplane will be able to set it outside the big QEMU lock. Signed-off-by: Paolo Bonzini --- hw/virtio/virtio-mmio.c | 6 +++--- hw/virtio/virtio-pci.c | 9 +++-- hw/virtio/virtio.c | 18 +- 3 files changed, 19 insertions(+), 14 deletions(-)