Re: [Qemu-devel] [PATCH 2/3] target-arm: fix support for vrecpe.

2011-02-17 Thread Peter Maydell
On 17 February 2011 17:51, Christophe Lyon wrote: >> ...and a runtime division just to get a constant 0.5? >> Better to just make_float64() on the appropriate bit >> pattern, I think. > > It makes sense. > Then, what about using the right bit patterns for 512 and 256? Not so worried about those

Re: [Qemu-devel] [PATCH 2/3] target-arm: fix support for vrecpe.

2011-02-17 Thread Christophe Lyon
>> +float_status *s = &env->vfp.standard_fp_status; >> +float64 one = int64_to_float64(1, s); > You don't need to create a variable for this, float64_one > will do what you want. OK >> +/* q = (int)(a * 512.0) */ >> +float64 x512 = int64_to_float64(512, s); >> +float64 q = f

Re: [Qemu-devel] [PATCH 2/3] target-arm: fix support for vrecpe.

2011-02-17 Thread Peter Maydell
On 16 February 2011 17:59, wrote: > From: Christophe Lyon > > Now use the same algorithm as described in the ARM ARM. > > Signed-off-by: Christophe Lyon Mostly looks good, and seems to pass random testing. > +    float_status *s = &env->vfp.standard_fp_status; > +    float64 one = int64_to_fl

[Qemu-devel] [PATCH 2/3] target-arm: fix support for vrecpe.

2011-02-16 Thread christophe.lyon
From: Christophe Lyon Now use the same algorithm as described in the ARM ARM. Signed-off-by: Christophe Lyon --- target-arm/helper.c | 84 +++--- 1 files changed, 72 insertions(+), 12 deletions(-) diff --git a/target-arm/helper.c b/target-arm/help