Re: [Qemu-devel] [PATCH 2/3] target/sparc: convert to DisasContextBase

2018-02-18 Thread Richard Henderson
On 02/15/2018 03:17 PM, Emilio G. Cota wrote: > - The original meaning of ctx.singlestep is > cs->singlestep_enabled || singlestep > , which required a little extra work since base.singlestep_enabled > only gets its value from cs->singlestep_enabled. These sort of inconsistencies should be

[Qemu-devel] [PATCH 2/3] target/sparc: convert to DisasContextBase

2018-02-15 Thread Emilio G. Cota
Notes: - pc and npc are left unmodified, since they can point to out-of-TB jump targets. - Got rid of last_pc in gen_intermediate_code(), using base.pc_next instead. Only update pc_next (1) on a breakpoint (so that tb->size includes the insn), and (2) after reading the current instruction