Re: [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-29 Thread Peter Krempa
On Mon, Jan 28, 2019 at 17:55:14 +0100, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben: > [...] > >> 2) Is actually using 'scsi-cd'/'scsi-hd' the better option than > >> 'scsi-disk'? > > > > Yes, scsi-disk is a legacy device. Maybe we shoul

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.01.2019 um 17:55 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben: >> [...] >> >> 2) Is actually using 'scsi-cd'/'scsi-hd' the better option than >> >> 'scsi-disk'? >> > >> > Yes, scsi-disk is a legac

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Kevin Wolf
Am 28.01.2019 um 17:55 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben: > [...] > >> 2) Is actually using 'scsi-cd'/'scsi-hd' the better option than > >> 'scsi-disk'? > > > > Yes, scsi-disk is a legacy device. Maybe we should forma

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben: [...] >> 2) Is actually using 'scsi-cd'/'scsi-hd' the better option than >> 'scsi-disk'? > > Yes, scsi-disk is a legacy device. Maybe we should formally deprecate > it. There's an internal use in scsi_bus_legacy_add_drive(

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Kevin Wolf
Am 28.01.2019 um 09:50 hat Peter Krempa geschrieben: > On Fri, Jan 25, 2019 at 18:46:52 +0100, Kevin Wolf wrote: > > The new device_id property specifies which value to use for the vendor > > specific designator in the Device Identification VPD page. > > > > In particular, this is necessary for li

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Peter Krempa
On Mon, Jan 28, 2019 at 09:50:41 +0100, Peter Krempa wrote: > On Fri, Jan 25, 2019 at 18:46:52 +0100, Kevin Wolf wrote: > > The new device_id property specifies which value to use for the vendor > > specific designator in the Device Identification VPD page. > > > > In particular, this is necessary

Re: [Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-28 Thread Peter Krempa
On Fri, Jan 25, 2019 at 18:46:52 +0100, Kevin Wolf wrote: > The new device_id property specifies which value to use for the vendor > specific designator in the Device Identification VPD page. > > In particular, this is necessary for libvirt to maintain guest ABI > compatibility when no serial numb

[Qemu-devel] [PATCH 2/3] scsi-disk: Add device_id property

2019-01-25 Thread Kevin Wolf
The new device_id property specifies which value to use for the vendor specific designator in the Device Identification VPD page. In particular, this is necessary for libvirt to maintain guest ABI compatibility when no serial number is given and a VM is switched from -drive (where the BlockBackend