Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 15:09, Jens Freimann wrote: > On Thu, Jan 03, 2013 at 01:55:19PM +0100, Alexander Graf wrote: >> >> On 18.12.2012, at 18:50, Jens Freimann wrote: >> >>> Add a CPU reset handler to have all CPUs in a PoP compliant >>> state. >>> >>> Signed-off-by: Jens Freimann >>> >>> --- >

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2013-01-04 Thread Jens Freimann
On Thu, Jan 03, 2013 at 01:55:19PM +0100, Alexander Graf wrote: > > On 18.12.2012, at 18:50, Jens Freimann wrote: > > > Add a CPU reset handler to have all CPUs in a PoP compliant > > state. > > > > Signed-off-by: Jens Freimann > > > > --- > > v2 -> v3: > > * remove FIXME > > * separate parent

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2013-01-04 Thread Jens Freimann
On Thu, Jan 03, 2013 at 01:50:22PM +0100, Alexander Graf wrote: > > On 18.12.2012, at 18:50, Jens Freimann wrote: > > > Add a CPU reset handler to have all CPUs in a PoP compliant > > state. > > > > Signed-off-by: Jens Freimann > > > > --- > > v2 -> v3: > > * remove FIXME > > * separate parent

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2013-01-03 Thread Alexander Graf
On 18.12.2012, at 18:50, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > > --- > v2 -> v3: > * remove FIXME > * separate parent reset from local reset by adding a while line > * use defines for register reset values

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2013-01-03 Thread Alexander Graf
On 18.12.2012, at 18:50, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > > --- > v2 -> v3: > * remove FIXME > * separate parent reset from local reset by adding a while line > * use defines for register reset values

[Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-18 Thread Jens Freimann
Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- v2 -> v3: * remove FIXME * separate parent reset from local reset by adding a while line * use defines for register reset values v1 -> v2: * move setting of control registers and psa to s390_cpu_

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-17 Thread Alexander Graf
On 17.12.2012, at 18:21, Andreas Färber wrote: > Am 17.12.2012 15:49, schrieb Alexander Graf: >> >> On 14.12.2012, at 17:46, Jens Freimann wrote: >> >>> @@ -37,12 +42,30 @@ static void s390_cpu_reset(CPUState *s) >>>log_cpu_state(env, 0); >>>} >>> >>> -scc->parent_reset(s); >>>

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-17 Thread Andreas Färber
Am 17.12.2012 15:49, schrieb Alexander Graf: > > On 14.12.2012, at 17:46, Jens Freimann wrote: > >> @@ -37,12 +42,30 @@ static void s390_cpu_reset(CPUState *s) >> log_cpu_state(env, 0); >> } >> >> -scc->parent_reset(s); >> +s390_del_running_cpu(env); >> >> +scc->parent_res

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-17 Thread Jens Freimann
On Mon, Dec 17, 2012 at 03:49:41PM +0100, Alexander Graf wrote: > > On 14.12.2012, at 17:46, Jens Freimann wrote: > > > Add a CPU reset handler to have all CPUs in a PoP compliant > > state. > > > > Signed-off-by: Jens Freimann > > > > --- > > v2 -> v3: > > * explain in comment which code set

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-17 Thread Alexander Graf
On 14.12.2012, at 17:46, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > > --- > v2 -> v3: > * explain in comment which code sets cpu 0 to running during IPL > > v1 -> v2: > * move setting of control registers and

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-17 Thread Jens Freimann
On Sun, Dec 16, 2012 at 04:30:21PM +0100, Andreas Färber wrote: > Am 14.12.2012 17:46, schrieb Jens Freimann: > > Add a CPU reset handler to have all CPUs in a PoP compliant > > state. > > > > Signed-off-by: Jens Freimann > > The logic looks okay now. Some comments inline. > > > --- > > v2 -> v

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-16 Thread Andreas Färber
Am 14.12.2012 17:46, schrieb Jens Freimann: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann The logic looks okay now. Some comments inline. > --- > v2 -> v3: > * explain in comment which code sets cpu 0 to running during IPL > > v1 -> v2

[Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-14 Thread Jens Freimann
Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- v2 -> v3: * explain in comment which code sets cpu 0 to running during IPL v1 -> v2: * move setting of control registers and psa to s390_cpu_reset and call it from the new s390_machine_cpu_res

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-12 Thread Jens Freimann
On Wed, Dec 12, 2012 at 02:38:40PM +0100, Alexander Graf wrote: > > On 12.12.2012, at 14:08, Jens Freimann wrote: > > > Add a CPU reset handler to have all CPUs in a PoP compliant > > state. > > > > Signed-off-by: Jens Freimann > > > > --- > > v1 -> v2: > > * move setting of control registers

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-12 Thread Alexander Graf
On 12.12.2012, at 14:08, Jens Freimann wrote: > Add a CPU reset handler to have all CPUs in a PoP compliant > state. > > Signed-off-by: Jens Freimann > > --- > v1 -> v2: > * move setting of control registers and psa to s390_cpu_reset > and call it from the new s390_machine_cpu_reset_cb() > T

[Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-12 Thread Jens Freimann
Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- v1 -> v2: * move setting of control registers and psa to s390_cpu_reset and call it from the new s390_machine_cpu_reset_cb() This makes it more similar to how it is done on x86 * in s390_cpu_r