Re: [Qemu-devel] [PATCH 2/3] qmp: add query-cpus-fast

2018-02-13 Thread Viktor Mihajlovski
On 12.02.2018 17:50, Dr. David Alan Gilbert wrote: [...] >> diff --git a/hmp.c b/hmp.c >> index a6b94b7..598bfe5 100644 >> --- a/hmp.c >> +++ b/hmp.c >> @@ -410,6 +410,27 @@ void hmp_info_cpus(Monitor *mon, const QDict *qdict) >> qapi_free_CpuInfoList(cpu_list); >> } >> >> +void hmp_info_cp

Re: [Qemu-devel] [PATCH 2/3] qmp: add query-cpus-fast

2018-02-12 Thread David Hildenbrand
On 12.02.2018 13:14, Viktor Mihajlovski wrote: > From: Luiz Capitulino > > The query-cpus command has an extremely serious side effect: > it always interrupts all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some workloads. And most of the

Re: [Qemu-devel] [PATCH 2/3] qmp: add query-cpus-fast

2018-02-12 Thread Dr. David Alan Gilbert
* Viktor Mihajlovski (mihaj...@linux.vnet.ibm.com) wrote: > From: Luiz Capitulino > > The query-cpus command has an extremely serious side effect: > it always interrupts all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some workloads. And m

Re: [Qemu-devel] [PATCH 2/3] qmp: add query-cpus-fast

2018-02-12 Thread Cornelia Huck
On Mon, 12 Feb 2018 13:14:31 +0100 Viktor Mihajlovski wrote: > From: Luiz Capitulino > > The query-cpus command has an extremely serious side effect: > it always interrupts all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some workloads.

[Qemu-devel] [PATCH 2/3] qmp: add query-cpus-fast

2018-02-12 Thread Viktor Mihajlovski
From: Luiz Capitulino The query-cpus command has an extremely serious side effect: it always interrupts all running vCPUs so that they can run ioctl calls. This can cause a huge performance degradation for some workloads. And most of the information retrieved by the ioctl calls are not even used