Re: [Qemu-devel] [PATCH 2/3] qemu-img: Use only string options in img_open_opts

2018-05-02 Thread Max Reitz
On 2018-05-03 00:00, Eric Blake wrote: > On 05/02/2018 03:20 PM, Max Reitz wrote: >> img_open_opts() takes a QemuOpts and converts them to a QDict, so all >> values therein are strings.  Then it may try to call qdict_get_bool(), >> however, which will fail with a segmentation fault every time: > >

Re: [Qemu-devel] [PATCH 2/3] qemu-img: Use only string options in img_open_opts

2018-05-02 Thread Eric Blake
On 05/02/2018 03:20 PM, Max Reitz wrote: img_open_opts() takes a QemuOpts and converts them to a QDict, so all values therein are strings. Then it may try to call qdict_get_bool(), however, which will fail with a segmentation fault every time: I have no idea if it's worth fixing qdict_get_bool

[Qemu-devel] [PATCH 2/3] qemu-img: Use only string options in img_open_opts

2018-05-02 Thread Max Reitz
img_open_opts() takes a QemuOpts and converts them to a QDict, so all values therein are strings. Then it may try to call qdict_get_bool(), however, which will fail with a segmentation fault every time: $ ./qemu-img info -U --image-opts \ driver=file,filename=/dev/null,force-share=off [1]