Re: [Qemu-devel] [PATCH 2/3] memory: Refactor common shifting code from accessors

2018-09-27 Thread Philippe Mathieu-Daudé
On 9/27/18 9:00 AM, Peter Maydell wrote: > On 27 September 2018 at 01:24, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> memory.c | 30 +- >> 1 file changed, 21 insertions(+), 9 deletions(-) >> > > NB that this patch will have a (fai

Re: [Qemu-devel] [PATCH 2/3] memory: Refactor common shifting code from accessors

2018-09-27 Thread Peter Maydell
On 27 September 2018 at 01:24, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > memory.c | 30 +- > 1 file changed, 21 insertions(+), 9 deletions(-) > NB that this patch will have a (fairly trivial) conflict with the "remove oldmmio acces

Re: [Qemu-devel] [PATCH 2/3] memory: Refactor common shifting code from accessors

2018-09-26 Thread Cédric Le Goater
Reviewed-by: Cédric Le Goater Thanks, C. On 9/27/18 2:24 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > memory.c | 30 +- > 1 file changed, 21 insertions(+), 9 deletions(-) > > diff --git a/memory.c b/memory.c > index 385b9d35

[Qemu-devel] [PATCH 2/3] memory: Refactor common shifting code from accessors

2018-09-26 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- memory.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/memory.c b/memory.c index 385b9d3590..48edf7dc23 100644 --- a/memory.c +++ b/memory.c @@ -374,6 +374,21 @@ static void adjust_endianness(MemoryReg