Re: [Qemu-devel] [PATCH 2/3] make latency configurable

2019-03-15 Thread Martin Schrodt
Hi, On 3/15/19 8:53 AM, Gerd Hoffmann wrote: > Hi, > >> r = pa_stream_connect_playback (stream, dev, attr, >> PA_STREAM_INTERPOLATE_TIMING >> -#ifdef PA_STREAM_ADJUST_LATENCY >> |PA_STREAM_ADJUST_LATENCY

Re: [Qemu-devel] [PATCH 2/3] make latency configurable

2019-03-15 Thread Gerd Hoffmann
Hi, > r = pa_stream_connect_playback (stream, dev, attr, > PA_STREAM_INTERPOLATE_TIMING > -#ifdef PA_STREAM_ADJUST_LATENCY > |PA_STREAM_ADJUST_LATENCY > -#endif Unrelated change, separate commit please.

Re: [Qemu-devel] [PATCH 2/3] make latency configurable

2019-03-14 Thread Eric Blake
On 3/14/19 8:38 AM, Martin Schrodt wrote: > Signed-off-by: Martin Schrodt The subject line says "what" (good) but doesn't state everything the patch is doing (you are not only making it configurable, but you are changing the default). The commit body should say "why" (missing), and mention all t

[Qemu-devel] [PATCH 2/3] make latency configurable

2019-03-14 Thread Martin Schrodt
Signed-off-by: Martin Schrodt --- audio/paaudio.c | 18 +++--- qapi/audio.json | 5 - 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 1a799ca3e7..c9007fdb01 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -500,16 +500