Re: [Qemu-devel] [PATCH 2/3] hw/s390x/css: Remove QEMU_PACKED from struct SenseId

2018-09-25 Thread Thomas Huth
On 2018-09-25 18:52, David Hildenbrand wrote: > On 25/09/2018 17:20, Thomas Huth wrote: >> The uint16_t member cu_type of struct SenseId is not naturally aligned, >> and since the struct is marked with QEMU_PACKED, this can lead to >> unaligned memory accesses - which does not work on architectures

Re: [Qemu-devel] [PATCH 2/3] hw/s390x/css: Remove QEMU_PACKED from struct SenseId

2018-09-25 Thread David Hildenbrand
On 25/09/2018 17:20, Thomas Huth wrote: > The uint16_t member cu_type of struct SenseId is not naturally aligned, > and since the struct is marked with QEMU_PACKED, this can lead to > unaligned memory accesses - which does not work on architectures like > Sparc. Thus remove the QEMU_PACKED here and

Re: [Qemu-devel] [PATCH 2/3] hw/s390x/css: Remove QEMU_PACKED from struct SenseId

2018-09-25 Thread Cornelia Huck
On Tue, 25 Sep 2018 18:43:22 +0200 Thomas Huth wrote: > On 2018-09-25 18:14, Cornelia Huck wrote: > > On Tue, 25 Sep 2018 17:20:08 +0200 > > Thomas Huth wrote: > > > >> The uint16_t member cu_type of struct SenseId is not naturally aligned, > >> and since the struct is marked with QEMU_PACKED

Re: [Qemu-devel] [PATCH 2/3] hw/s390x/css: Remove QEMU_PACKED from struct SenseId

2018-09-25 Thread Thomas Huth
On 2018-09-25 18:14, Cornelia Huck wrote: > On Tue, 25 Sep 2018 17:20:08 +0200 > Thomas Huth wrote: > >> The uint16_t member cu_type of struct SenseId is not naturally aligned, >> and since the struct is marked with QEMU_PACKED, this can lead to >> unaligned memory accesses - which does not work

Re: [Qemu-devel] [PATCH 2/3] hw/s390x/css: Remove QEMU_PACKED from struct SenseId

2018-09-25 Thread Peter Maydell
On 25 September 2018 at 17:14, Cornelia Huck wrote: > On Tue, 25 Sep 2018 17:20:08 +0200 > Thomas Huth wrote: > >> The uint16_t member cu_type of struct SenseId is not naturally aligned, >> and since the struct is marked with QEMU_PACKED, this can lead to >> unaligned memory accesses - which does

Re: [Qemu-devel] [PATCH 2/3] hw/s390x/css: Remove QEMU_PACKED from struct SenseId

2018-09-25 Thread Cornelia Huck
On Tue, 25 Sep 2018 17:20:08 +0200 Thomas Huth wrote: > The uint16_t member cu_type of struct SenseId is not naturally aligned, > and since the struct is marked with QEMU_PACKED, this can lead to > unaligned memory accesses - which does not work on architectures like > Sparc. Thus remove the QEMU

[Qemu-devel] [PATCH 2/3] hw/s390x/css: Remove QEMU_PACKED from struct SenseId

2018-09-25 Thread Thomas Huth
The uint16_t member cu_type of struct SenseId is not naturally aligned, and since the struct is marked with QEMU_PACKED, this can lead to unaligned memory accesses - which does not work on architectures like Sparc. Thus remove the QEMU_PACKED here and rather copy the struct byte by byte when we do