Re: [Qemu-devel] [PATCH 2/3] hw/arm/gic: Kill code duplication

2015-08-04 Thread Pavel Fedin
Hello! > > -memory_region_init_io(&s->cpuiomem[0], OBJECT(s), &gic_thiscpu_ops, s, > > - "gic_cpu", 0x100); > > This memory region is size 0x100, as the comment says it must be... > > > +if (s->revision != REV_NVIC) { > > +/* CPU interface (NVIC doesn't

Re: [Qemu-devel] [PATCH 2/3] hw/arm/gic: Kill code duplication

2015-08-04 Thread Peter Maydell
On 29 July 2015 at 12:54, Pavel Fedin wrote: > Extracted duplicated initialization code from SW-emulated and KVM GIC > implementations and put into gic_init_irqs_and_mmio() > > Signed-off-by: Pavel Fedin > @@ -1110,28 +1090,19 @@ static void arm_gic_realize(DeviceState *dev, Error > **errp) >

[Qemu-devel] [PATCH 2/3] hw/arm/gic: Kill code duplication

2015-07-29 Thread Pavel Fedin
Extracted duplicated initialization code from SW-emulated and KVM GIC implementations and put into gic_init_irqs_and_mmio() Signed-off-by: Pavel Fedin --- hw/intc/arm_gic.c| 61 +++- hw/intc/arm_gic_common.c | 37 +++