Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-05-01 Thread Stefan Hajnoczi
On Mon, Apr 29, 2013 at 09:51:47AM -0600, Eric Blake wrote: > On 04/29/2013 03:27 AM, Paolo Bonzini wrote: > > Il 29/04/2013 09:21, Stefan Hajnoczi ha scritto: > >>> I'd really love to see us change 'BlockJobInfo' to use an enum for > >>> 'type', instead of its open-coded 'str'. Likewise, the bloc

Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-04-29 Thread Eric Blake
On 04/29/2013 03:27 AM, Paolo Bonzini wrote: > Il 29/04/2013 09:21, Stefan Hajnoczi ha scritto: >>> I'd really love to see us change 'BlockJobInfo' to use an enum for >>> 'type', instead of its open-coded 'str'. Likewise, the block-job >>> related events in QMP/qmp-events.txt should be updated to

Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-04-29 Thread Paolo Bonzini
Il 29/04/2013 09:21, Stefan Hajnoczi ha scritto: > > I'd really love to see us change 'BlockJobInfo' to use an enum for > > 'type', instead of its open-coded 'str'. Likewise, the block-job > > related events in QMP/qmp-events.txt should be updated to refer to the > > enum instead of also being ope

Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-04-29 Thread Stefan Hajnoczi
On Fri, Apr 26, 2013 at 04:58:24PM -0600, Eric Blake wrote: > On 04/23/2013 10:25 AM, Stefan Hajnoczi wrote: > > @block-backup > > > > Start a point-in-time copy of a block device to a new destination. > > > > @device: the name of the device whose writes should be mirrored. > > > > @target: the

Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-04-26 Thread Eric Blake
On 04/23/2013 10:25 AM, Stefan Hajnoczi wrote: > @block-backup > > Start a point-in-time copy of a block device to a new destination. > > @device: the name of the device whose writes should be mirrored. > > @target: the target of the new image. If the file exists, or if it > is a devic

Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-04-26 Thread Eric Blake
On 04/26/2013 04:52 PM, Eric Blake wrote: > On 04/23/2013 10:25 AM, Stefan Hajnoczi wrote: >> @block-backup [hit send too soon] Subject line should mention block-backup, not block_backup. >> +## >> +{ 'command': 'block-backup', >> + 'data': { 'device': 'str', 'target': 'str', '*format': 'str',

Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-04-26 Thread Eric Blake
On 04/23/2013 10:25 AM, Stefan Hajnoczi wrote: > @block-backup > > Start a point-in-time copy of a block device to a new destination. > > @device: the name of the device whose writes should be mirrored. > +++ b/qapi-schema.json > @@ -1715,6 +1715,34 @@ > '*speed': 'int' } } > >

[Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-04-23 Thread Stefan Hajnoczi
@block-backup Start a point-in-time copy of a block device to a new destination. @device: the name of the device whose writes should be mirrored. @target: the target of the new image. If the file exists, or if it is a device, the existing file/device will be used as the new de