Re: [Qemu-devel] [PATCH 2/3] NBD proto: document additional error conditions

2016-03-28 Thread Eric Blake
On 03/28/2016 04:43 AM, Denis V. Lunev wrote: > From: Pavel Borzenkov > > It is unclear what the behaviour of a server should be if it receives > an unknown command. Similar uncertainty exists for command flags. > > Make it explicit that the server should return EINVAL in all such cases. I'd go

[Qemu-devel] [PATCH 2/3] NBD proto: document additional error conditions

2016-03-28 Thread Denis V. Lunev
From: Pavel Borzenkov It is unclear what the behaviour of a server should be if it receives an unknown command. Similar uncertainty exists for command flags. Make it explicit that the server should return EINVAL in all such cases. Signed-off-by: Pavel Borzenkov Reviewed-by: Roman Kagan Signed