Re: [Qemu-devel] [PATCH 2/2] win32: add readv/writev emulation

2013-04-23 Thread Paolo Bonzini
> Hi Paolo, > > your patch looks good, but maybe you could modify the signatures > of readv, writev to match the Linux originals (missing const, use int): > > ssize_t readv(int fd, const struct iovec *iov, int iovcnt); > ssize_t writev(int fd, const struct iovec *iov, int iovcnt); > > In

Re: [Qemu-devel] [PATCH 2/2] win32: add readv/writev emulation

2013-04-23 Thread Stefan Weil
Am 22.04.2013 20:53, schrieb Paolo Bonzini: > Commit e9d8fbf (qemu-file: do not use stdio for qemu_fdopen, 2013-03-27) > introduced a usage of writev, which mingw32 does not have. Even though > qemu_fdopen itself is not used on mingw32, the future-proof solution is > to add an implementation of it

[Qemu-devel] [PATCH 2/2] win32: add readv/writev emulation

2013-04-22 Thread Paolo Bonzini
Commit e9d8fbf (qemu-file: do not use stdio for qemu_fdopen, 2013-03-27) introduced a usage of writev, which mingw32 does not have. Even though qemu_fdopen itself is not used on mingw32, the future-proof solution is to add an implementation of it. This is simple and similar to how we emulate send