Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support

2015-04-13 Thread Cornelia Huck
On Mon, 13 Apr 2015 13:26:31 +0200 "Michael S. Tsirkin" wrote: > BTW I suspect the stats code is broken for > cross-endian platforms: it should do LE unconditinally, > should it not? Stats are guest-endian for legacy, so no. Only the config space is always LE.

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support

2015-04-13 Thread Cornelia Huck
On Mon, 13 Apr 2015 13:49:42 +0200 "Michael S. Tsirkin" wrote: > On Mon, Apr 13, 2015 at 01:35:21PM +0200, Cornelia Huck wrote: > > On Mon, 13 Apr 2015 13:26:31 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Apr 13, 2015 at 10:02:58AM +0200, Cornelia Huck wrote: > > > > > > Also, does

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 01:35:21PM +0200, Cornelia Huck wrote: > On Mon, 13 Apr 2015 13:26:31 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Apr 13, 2015 at 10:02:58AM +0200, Cornelia Huck wrote: > > > > Also, doesn't get_features need to be modified as well so that > > > VERSION_1 is adverti

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support

2015-04-13 Thread Cornelia Huck
On Mon, 13 Apr 2015 13:26:31 +0200 "Michael S. Tsirkin" wrote: > On Mon, Apr 13, 2015 at 10:02:58AM +0200, Cornelia Huck wrote: > > Also, doesn't get_features need to be modified as well so that > > VERSION_1 is advertised? > > virtio_pci_device_plugged seems to set it ATM. I'll re-test to conf

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 10:02:58AM +0200, Cornelia Huck wrote: > On Sun, 12 Apr 2015 17:00:48 +0200 > "Michael S. Tsirkin" wrote: > > > Virtio 1.0 doesn't include a modern balloon device. At some point we'll > > likely define an incompatible interface with a different ID and > > different semant

Re: [Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support

2015-04-13 Thread Cornelia Huck
On Sun, 12 Apr 2015 17:00:48 +0200 "Michael S. Tsirkin" wrote: > Virtio 1.0 doesn't include a modern balloon device. At some point we'll > likely define an incompatible interface with a different ID and > different semantics. But for now, it's not a big effort to support a > transitional balloo

[Qemu-devel] [PATCH 2/2] virtio-balloon: virtio 1 support

2015-04-12 Thread Michael S. Tsirkin
Virtio 1.0 doesn't include a modern balloon device. At some point we'll likely define an incompatible interface with a different ID and different semantics. But for now, it's not a big effort to support a transitional balloon device: this has the advantage of supporting existing drivers, transpar