Re: [Qemu-devel] [PATCH 2/2] tests: Add tmp105 unit test

2012-12-15 Thread Andreas Färber
Am 12.12.2012 15:44, schrieb Alex Horn: > Thanks so much for taking the initiative on creating functional tests > for the TMP105 hardware model. I am exciting to see these changes and > I am wondering if your QTests could be complemented with the following > standalone unit tests: > > > https:/

Re: [Qemu-devel] [PATCH 2/2] tests: Add tmp105 unit test

2012-12-12 Thread Andreas Färber
Am 12.12.2012 20:43, schrieb Blue Swirl: > On Wed, Dec 12, 2012 at 6:29 AM, Andreas Färber > wrote: >> +static void omap_i2c_send(uint8_t addr, const void *buf, uint16_t len) > > With const uint8_t *buf you could avoid a few casts below. Good idea, thanks. I was working with other data types be

Re: [Qemu-devel] [PATCH 2/2] tests: Add tmp105 unit test

2012-12-12 Thread Blue Swirl
On Wed, Dec 12, 2012 at 6:29 AM, Andreas Färber wrote: > Exercise all four commands of the TMP105, testing for an issue in the > I2C TX path. The test case is specific to the n800's OMAP I2C for now > and is the first test case for arm. > > Signed-off-by: Andreas Färber > --- > tests/Makefile

Re: [Qemu-devel] [PATCH 2/2] tests: Add tmp105 unit test

2012-12-12 Thread Alex Horn
Thanks so much for taking the initiative on creating functional tests for the TMP105 hardware model. I am exciting to see these changes and I am wondering if your QTests could be complemented with the following standalone unit tests: https://github.com/ahorn/benchmarks/blob/965e571d92e677e8e64a

[Qemu-devel] [PATCH 2/2] tests: Add tmp105 unit test

2012-12-11 Thread Andreas Färber
Exercise all four commands of the TMP105, testing for an issue in the I2C TX path. The test case is specific to the n800's OMAP I2C for now and is the first test case for arm. Signed-off-by: Andreas Färber --- tests/Makefile |2 + tests/tmp105-test.c | 205 +