Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2019-07-03 Thread Paolo Bonzini
On 01/07/19 16:42, Philippe Mathieu-Daudé wrote: > $ make check-qtest-x86_64 GTESTER_OPTIONS="-p /x86_64/acpi" > > But this commit removed the use of $GTESTER_OPTIONS, however it is > still documented: > > $ make check-help > [...] > The variable SPEED can be set to control the gtester speed sett

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2019-07-01 Thread Philippe Mathieu-Daudé
Hi Paolo, On 12/6/18 10:50 PM, Paolo Bonzini wrote: > gtester is deprecated by upstream glib (see for example the announcement > at https://blog.gtk.org/2018/07/11/news-from-glib-2-58/) and it does > not support tests that call g_test_skip in some glib stable releases. > > glib suggests instead u

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2019-02-11 Thread Paolo Bonzini
On 11/02/19 15:32, Kevin Wolf wrote: > $(patsubst %, check-%, $(check-unit-y) $(check-speed-y)): check-%: % > $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) > $(call quiet-command, \ > MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} \ >

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2019-02-11 Thread Kevin Wolf
Am 08.02.2019 um 18:16 hat Paolo Bonzini geschrieben: > On 08/02/19 17:00, Kevin Wolf wrote: > > Am 08.02.2019 um 14:46 hat Paolo Bonzini geschrieben: > >> On 08/02/19 13:48, Kevin Wolf wrote: > >>> I just wanted to work on a unit test and found that a simple 'make > >>> check-tests/test-bdrv-drain

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2019-02-08 Thread Paolo Bonzini
On 08/02/19 17:00, Kevin Wolf wrote: > Am 08.02.2019 um 14:46 hat Paolo Bonzini geschrieben: >> On 08/02/19 13:48, Kevin Wolf wrote: >>> I just wanted to work on a unit test and found that a simple 'make >>> check-tests/test-bdrv-drain' (which used to build and run the test with >>> a single comman

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2019-02-08 Thread Kevin Wolf
Am 08.02.2019 um 14:46 hat Paolo Bonzini geschrieben: > On 08/02/19 13:48, Kevin Wolf wrote: > > I just wanted to work on a unit test and found that a simple 'make > > check-tests/test-bdrv-drain' (which used to build and run the test with > > a single command) doesn't work any more. > > > > git b

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2019-02-08 Thread Paolo Bonzini
On 08/02/19 13:48, Kevin Wolf wrote: > I just wanted to work on a unit test and found that a simple 'make > check-tests/test-bdrv-drain' (which used to build and run the test with > a single command) doesn't work any more. > > git bisect points to this commit. What's wrong with "tests/test-bdrv-d

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2019-02-08 Thread Kevin Wolf
Am 06.12.2018 um 22:50 hat Paolo Bonzini geschrieben: > gtester is deprecated by upstream glib (see for example the announcement > at https://blog.gtk.org/2018/07/11/news-from-glib-2-58/) and it does > not support tests that call g_test_skip in some glib stable releases. > > glib suggests instead

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2018-12-06 Thread Thomas Huth
On 2018-12-06 22:50, Paolo Bonzini wrote: > gtester is deprecated by upstream glib (see for example the announcement > at https://blog.gtk.org/2018/07/11/news-from-glib-2-58/) and it does > not support tests that call g_test_skip in some glib stable releases. > > glib suggests instead using Automa

[Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2018-12-06 Thread Paolo Bonzini
gtester is deprecated by upstream glib (see for example the announcement at https://blog.gtk.org/2018/07/11/news-from-glib-2-58/) and it does not support tests that call g_test_skip in some glib stable releases. glib suggests instead using Automake's TAP support, which gtest itself supports since

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2018-11-30 Thread Paolo Bonzini
On 30/11/18 16:50, Daniel P. Berrangé wrote: > IIUC, this output is only seen when you with 'make check' passing V=1, > so most people won't see it. V=1 should be enabled by default on Patchew, so it will be visible in the CI logs. But anyway that's minor, there are more reasons why a custom beau

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2018-11-30 Thread Daniel P . Berrangé
On Thu, Nov 29, 2018 at 06:45:31PM +0100, Paolo Bonzini wrote: > gtester is deprecated by upstream glib and it does not support tests > that call g_test_skip in some glib stable releases. > > glib suggests instead using Automake's TAP support. We do not support > Automake, but we can copy the cod

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2018-11-29 Thread Paolo Bonzini
On 29/11/18 22:06, Eric Blake wrote: > On 11/29/18 11:45 AM, Paolo Bonzini wrote: >> gtester is deprecated by upstream glib and it does not support tests >> that call g_test_skip in some glib stable releases. >> >> glib suggests instead using Automake's TAP support.  We do not support >> Automake,

Re: [Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2018-11-29 Thread Eric Blake
On 11/29/18 11:45 AM, Paolo Bonzini wrote: gtester is deprecated by upstream glib and it does not support tests that call g_test_skip in some glib stable releases. glib suggests instead using Automake's TAP support. We do not support Automake, but we can copy the code that beautifies the TAP ou

[Qemu-devel] [PATCH 2/2] test: replace gtester with a TAP driver

2018-11-29 Thread Paolo Bonzini
gtester is deprecated by upstream glib and it does not support tests that call g_test_skip in some glib stable releases. glib suggests instead using Automake's TAP support. We do not support Automake, but we can copy the code that beautifies the TAP output and use it. I chose to use the Perl cop