[Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2015-05-05 Thread Marc-André Lureau
The spice server is polling on write, unless SPICE_CHAR_DEVICE_NOTIFY_WRITABLE flag is set. In this case, qemu must call spice_server_char_device_wakeup() when the frontend is writable. Signed-off-by: Marc-André Lureau --- spice-qemu-char.c | 11 +++ 1 file changed, 11 insertions(+) dif

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2015-05-05 Thread Gerd Hoffmann
Hi, > > Ok then. Added to spice queue. Fails to build, but that looks like > > just being the dependency on amits patch and should go away once that > > one is upstream. > > The dependency patch is now in tree, please pick this series up. Hmm, not in my queue any more, probably dropped at so

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2015-05-04 Thread Amit Shah
Hi Gerd, On (Mon) 27 Oct 2014 [12:57:57], Gerd Hoffmann wrote: > On Mo, 2014-10-27 at 12:45 +0100, Marc-André Lureau wrote: > > Hi > > > > > > On Mon, Oct 27, 2014 at 9:08 AM, Gerd Hoffmann > > wrote: > > > +static void spice_chr_accept_input(struct CharDriverState > > *chr) > >

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-28 Thread Amit Shah
On (Mon) 27 Oct 2014 [17:32:31], Marc-André Lureau wrote: > On Mon, Oct 27, 2014 at 1:43 PM, Amit Shah wrote: > > > Great, so there's no other change required to actually use the > > functionality in my patch? Does my patch fit your need fine, or do > > you need to tweak the notification somehow

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-27 Thread Marc-André Lureau
On Mon, Oct 27, 2014 at 1:43 PM, Amit Shah wrote: > Great, so there's no other change required to actually use the > functionality in my patch? Does my patch fit your need fine, or do > you need to tweak the notification somehow? > > It seems to be working nicely. > It would be great to get yo

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-27 Thread Amit Shah
Hi, On (Fri) 24 Oct 2014 [11:00:54], Marc-André Lureau wrote: > The spice server is polling on write, unless > SPICE_CHAR_DEVICE_NOTIFY_WRITABLE flag is set. In this case, qemu must > call spice_server_char_device_wakeup() when the frontend is writable. Great, so there's no other change required

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-27 Thread Gerd Hoffmann
On Mo, 2014-10-27 at 12:45 +0100, Marc-André Lureau wrote: > Hi > > > On Mon, Oct 27, 2014 at 9:08 AM, Gerd Hoffmann > wrote: > > +static void spice_chr_accept_input(struct CharDriverState > *chr) > > +{ > > +SpiceCharDriver *s = chr->opaque; > > + >

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-27 Thread Marc-André Lureau
Hi On Mon, Oct 27, 2014 at 9:08 AM, Gerd Hoffmann wrote: > > +static void spice_chr_accept_input(struct CharDriverState *chr) > > +{ > > +SpiceCharDriver *s = chr->opaque; > > + > > +spice_server_char_device_wakeup(&s->sin); > > Does this build on older spice versions? I'd suspect this

Re: [Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-27 Thread Gerd Hoffmann
On Fr, 2014-10-24 at 11:00 +0200, Marc-André Lureau wrote: > The spice server is polling on write, unless > SPICE_CHAR_DEVICE_NOTIFY_WRITABLE flag is set. In this case, qemu must > call spice_server_char_device_wakeup() when the frontend is writable. > > Signed-off-by: Marc-André Lureau > --- >

[Qemu-devel] [PATCH 2/2] spice-char: notify the server when chardev is writable

2014-10-24 Thread Marc-André Lureau
The spice server is polling on write, unless SPICE_CHAR_DEVICE_NOTIFY_WRITABLE flag is set. In this case, qemu must call spice_server_char_device_wakeup() when the frontend is writable. Signed-off-by: Marc-André Lureau --- spice-qemu-char.c | 11 +++ 1 file changed, 11 insertions(+) dif