Re: [Qemu-devel] [PATCH 2/2] qemu-nbd: Improve error reporting

2010-03-19 Thread Ryota Ozaki
On Sat, Mar 20, 2010 at 2:26 PM, malc wrote: > On Sat, 20 Mar 2010, Ryota Ozaki wrote: > >> - use err(3) instead of errx(3) if errno is available >>   to report why failed >> - let fail prior to daemon(3) if opening a nbd file >>   is likely to fail after daemonizing to avoid silent >>   failure e

Re: [Qemu-devel] [PATCH 2/2] qemu-nbd: Improve error reporting

2010-03-19 Thread malc
On Sat, 20 Mar 2010, Ryota Ozaki wrote: > - use err(3) instead of errx(3) if errno is available > to report why failed > - let fail prior to daemon(3) if opening a nbd file > is likely to fail after daemonizing to avoid silent > failure exit I'm under impression that you and the original au

[Qemu-devel] [PATCH 2/2] qemu-nbd: Improve error reporting

2010-03-19 Thread Ryota Ozaki
- use err(3) instead of errx(3) if errno is available to report why failed - let fail prior to daemon(3) if opening a nbd file is likely to fail after daemonizing to avoid silent failure exit --- qemu-nbd.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --gi