Re: [Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-07-03 Thread Eric Blake
On 07/03/2018 12:51 AM, Markus Armbruster wrote: Eric Blake writes: On 07/02/2018 01:48 PM, Markus Armbruster wrote: Eric Blake writes: Now that we have useful access to the type name as a comment in the generated qapi-introspect.c, we don't need to regenerate code with a temporary -u opti

Re: [Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-07-02 Thread Markus Armbruster
Eric Blake writes: > On 07/02/2018 01:48 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Now that we have useful access to the type name as a comment >>> in the generated qapi-introspect.c, we don't need to regenerate >>> code with a temporary -u option just to get at type names. >>> >

Re: [Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-07-02 Thread Eric Blake
On 07/02/2018 01:48 PM, Markus Armbruster wrote: Eric Blake writes: Now that we have useful access to the type name as a comment in the generated qapi-introspect.c, we don't need to regenerate code with a temporary -u option just to get at type names. Signed-off-by: Eric Blake I occasional

Re: [Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-07-02 Thread Markus Armbruster
Eric Blake writes: > Now that we have useful access to the type name as a comment > in the generated qapi-introspect.c, we don't need to regenerate > code with a temporary -u option just to get at type names. > > Signed-off-by: Eric Blake I occasionally feed output of query-qmp-schema to ad hoc

Re: [Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-06-29 Thread Eduardo Habkost
On Fri, Jun 29, 2018 at 02:55:44PM -0500, Eric Blake wrote: > Now that we have useful access to the type name as a comment > in the generated qapi-introspect.c, we don't need to regenerate > code with a temporary -u option just to get at type names. > > Signed-off-by: Eric Blake Reviewed-by: Edu

[Qemu-devel] [PATCH 2/2] qapi: Drop qapi-gen --unmask option

2018-06-29 Thread Eric Blake
Now that we have useful access to the type name as a comment in the generated qapi-introspect.c, we don't need to regenerate code with a temporary -u option just to get at type names. Signed-off-by: Eric Blake --- scripts/qapi-gen.py| 5 + scripts/qapi/introspect.py | 12 ---