Re: [Qemu-devel] [PATCH 2/2] pc-dimm: remove realize callback

2019-02-22 Thread Wei Yang
On Thu, Feb 21, 2019 at 03:37:53PM +0100, Igor Mammedov wrote: >On Tue, 19 Feb 2019 13:36:57 +0100 >Philippe Mathieu-Daudé wrote: > >> On 2/19/19 7:07 AM, Wei Yang wrote: >> > PCDIMM's realize callback is introduced to do proper setup for NVDIMM. >> > >> > Currently the NVDIMM setup task is nvdim

Re: [Qemu-devel] [PATCH 2/2] pc-dimm: remove realize callback

2019-02-21 Thread Igor Mammedov
On Tue, 19 Feb 2019 13:36:57 +0100 Philippe Mathieu-Daudé wrote: > On 2/19/19 7:07 AM, Wei Yang wrote: > > PCDIMM's realize callback is introduced to do proper setup for NVDIMM. > > > > Currently the NVDIMM setup task is nvdimm_prepare_memory_region(), which > > is done in pre_plug stage. This m

Re: [Qemu-devel] [PATCH 2/2] pc-dimm: remove realize callback

2019-02-19 Thread Wei Yang
On Tue, Feb 19, 2019 at 01:36:57PM +0100, Philippe Mathieu-Daudé wrote: >On 2/19/19 7:07 AM, Wei Yang wrote: >> PCDIMM's realize callback is introduced to do proper setup for NVDIMM. >> >> Currently the NVDIMM setup task is nvdimm_prepare_memory_region(), which >> is done in pre_plug stage. This m

Re: [Qemu-devel] [PATCH 2/2] pc-dimm: remove realize callback

2019-02-19 Thread Philippe Mathieu-Daudé
On 2/19/19 7:07 AM, Wei Yang wrote: > PCDIMM's realize callback is introduced to do proper setup for NVDIMM. > > Currently the NVDIMM setup task is nvdimm_prepare_memory_region(), which > is done in pre_plug stage. This means related task has already been done > at realize point. > > This patch r

[Qemu-devel] [PATCH 2/2] pc-dimm: remove realize callback

2019-02-18 Thread Wei Yang
PCDIMM's realize callback is introduced to do proper setup for NVDIMM. Currently the NVDIMM setup task is nvdimm_prepare_memory_region(), which is done in pre_plug stage. This means related task has already been done at realize point. This patch remove PCDIMM realize callback. Signed-off-by: Wei