Re: [Qemu-devel] [PATCH 2/2] nbd/server: add assert to nbd_negotiate_handle_info

2017-11-02 Thread Vladimir Sementsov-Ogievskiy
02.11.2017 21:06, Eric Blake wrote: On 11/01/2017 10:42 AM, Vladimir Sementsov-Ogievskiy wrote: Add an assert here to make last length assignment meaningful and following return without tail dropping obvious. Not quite sure I followed your explanation, which means it's difficult for me to propo

Re: [Qemu-devel] [PATCH 2/2] nbd/server: add assert to nbd_negotiate_handle_info

2017-11-02 Thread Eric Blake
On 11/01/2017 10:42 AM, Vladimir Sementsov-Ogievskiy wrote: > Add an assert here to make last length assignment meaningful and > following return without tail dropping obvious. Not quite sure I followed your explanation, which means it's difficult for me to propose an alternative wording. Maybe:

[Qemu-devel] [PATCH 2/2] nbd/server: add assert to nbd_negotiate_handle_info

2017-11-01 Thread Vladimir Sementsov-Ogievskiy
Add an assert here to make last length assignment meaningful and following return without tail dropping obvious. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 1 + 1 file changed, 1 insertion(+) diff --git a/nbd/server.c b/nbd/server.c index 7fcec0af7e..bcf0cdb47c 100644 --- a/