Re: [Qemu-devel] [PATCH 2/2] migration: store globalstate in pre_safe

2015-07-13 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We use global state in both savevm & migration. The easiest way is to >> put the setup in a single place. >> >> Signed-off-by: Juan Quintela > > I don't think this works; I think pre-save is called after the migr

Re: [Qemu-devel] [PATCH 2/2] migration: store globalstate in pre_safe

2015-07-10 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We use global state in both savevm & migration. The easiest way is to > put the setup in a single place. > > Signed-off-by: Juan Quintela I don't think this works; I think pre-save is called after the migration code has changed the runstate, so yo

[Qemu-devel] [PATCH 2/2] migration: store globalstate in pre_safe

2015-07-10 Thread Juan Quintela
We use global state in both savevm & migration. The easiest way is to put the setup in a single place. Signed-off-by: Juan Quintela --- migration/migration.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/migration/migration.c b/migration/mi