Re: [Qemu-devel] [PATCH 2/2] migration: Poison ramblock loops in migration

2018-06-06 Thread Cédric Le Goater
On 06/05/2018 06:25 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The migration code should be using the > RAMBLOCK_FOREACH_MIGRATABLE and qemu_ram_foreach_block_migratable > not the all-block versions; poison them so that we can't accidentally > use them. > > S

Re: [Qemu-devel] [PATCH 2/2] migration: Poison ramblock loops in migration

2018-06-06 Thread Peter Xu
On Wed, Jun 06, 2018 at 09:35:24AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Wed, Jun 06, 2018 at 11:36:00AM +0800, Peter Xu wrote: > > > On Tue, Jun 05, 2018 at 05:25:45PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan Gilb

Re: [Qemu-devel] [PATCH 2/2] migration: Poison ramblock loops in migration

2018-06-06 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Jun 06, 2018 at 11:36:00AM +0800, Peter Xu wrote: > > On Tue, Jun 05, 2018 at 05:25:45PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The migration code should be using the > > > RAMBLOCK_FOREACH

Re: [Qemu-devel] [PATCH 2/2] migration: Poison ramblock loops in migration

2018-06-05 Thread Peter Xu
On Wed, Jun 06, 2018 at 11:36:00AM +0800, Peter Xu wrote: > On Tue, Jun 05, 2018 at 05:25:45PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The migration code should be using the > > RAMBLOCK_FOREACH_MIGRATABLE and qemu_ram_foreach_block_migratable > > n

[Qemu-devel] [PATCH 2/2] migration: Poison ramblock loops in migration

2018-06-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The migration code should be using the RAMBLOCK_FOREACH_MIGRATABLE and qemu_ram_foreach_block_migratable not the all-block versions; poison them so that we can't accidentally use them. Signed-off-by: Dr. David Alan Gilbert --- include/exec/ramlist.h | 4 +++-