Re: [Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode

2016-05-24 Thread Fam Zheng
On Tue, 05/24 19:47, Laszlo Ersek wrote: > Which I think satisfies (a->mr == b->mr), but falsifies (a->romd_mode == > b->romd_mode). > > In effect, the patch seems to allow merging and equality between FlatRange > objects when they only differ in romd_mode, and that's wrong. > > Given that the co

Re: [Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode

2016-05-24 Thread Paolo Bonzini
On 24/05/2016 19:47, Laszlo Ersek wrote: > Which I think satisfies (a->mr == b->mr), but falsifies (a->romd_mode > == b->romd_mode). > > In effect, the patch seems to allow merging and equality between > FlatRange objects when they only differ in romd_mode, and that's > wrong. > > Given that th

Re: [Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode

2016-05-24 Thread Laszlo Ersek
On 03/25/16 11:10, Fam Zheng wrote: > Its value is alway set to mr->romd_mode, so the removed comparisons are > fully superseded by "a->mr == b->mr". > > Signed-off-by: Fam Zheng > --- > memory.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/memory.c b/memory.c > index d5b75f2..26

[Qemu-devel] [PATCH 2/2] memory: Drop FlatRange.romd_mode

2016-03-25 Thread Fam Zheng
Its value is alway set to mr->romd_mode, so the removed comparisons are fully superseded by "a->mr == b->mr". Signed-off-by: Fam Zheng --- memory.c | 4 1 file changed, 4 deletions(-) diff --git a/memory.c b/memory.c index d5b75f2..26af83f 100644 --- a/memory.c +++ b/memory.c @@ -224,7 +22