Re: [Qemu-devel] [PATCH 2/2] cadence_gem: avoid stack-writing buffer-overrun

2012-06-10 Thread Stefan Weil
Am 14.05.2012 06:57, schrieb Peter Crosthwaite: ACK and Thanks Jim, Reviewed-by: Peter A.G. Crosthwaite On Fri, May 11, 2012 at 2:19 AM, Jim Meyering wrote: From: Jim Meyering Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number of bytes to clear. The latter would always clear

Re: [Qemu-devel] [PATCH 2/2] cadence_gem: avoid stack-writing buffer-overrun

2012-05-13 Thread Peter Crosthwaite
ACK and Thanks Jim, Reviewed-by: Peter A.G. Crosthwaite On Fri, May 11, 2012 at 2:19 AM, Jim Meyering wrote: > From: Jim Meyering > > Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number > of bytes to clear.  The latter would always clear 4 or 8 > bytes, possibly writing beyond the en

[Qemu-devel] [PATCH 2/2] cadence_gem: avoid stack-writing buffer-overrun

2012-05-10 Thread Jim Meyering
From: Jim Meyering Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number of bytes to clear. The latter would always clear 4 or 8 bytes, possibly writing beyond the end of that stack buffer. Alternatively, depending on the value of the "size" parameter, it could fail to initialize the end