Re: [Qemu-devel] [PATCH 2/2] ahci: fix signature generation

2015-07-08 Thread John Snow
On 07/08/2015 08:56 AM, Stefan Hajnoczi wrote: > On Tue, Jul 07, 2015 at 01:15:02PM -0400, John Snow wrote: >> >> >> On 07/07/2015 04:49 AM, Stefan Hajnoczi wrote: >>> On Mon, Jul 06, 2015 at 05:49:52PM -0400, John Snow wrote: The initial register device-to-host FIS no longer needs to specia

Re: [Qemu-devel] [PATCH 2/2] ahci: fix signature generation

2015-07-08 Thread Stefan Hajnoczi
On Tue, Jul 07, 2015 at 01:15:02PM -0400, John Snow wrote: > > > On 07/07/2015 04:49 AM, Stefan Hajnoczi wrote: > > On Mon, Jul 06, 2015 at 05:49:52PM -0400, John Snow wrote: > >> The initial register device-to-host FIS no longer needs to specially > >> set certain fields, as these can be handled

Re: [Qemu-devel] [PATCH 2/2] ahci: fix signature generation

2015-07-07 Thread John Snow
On 07/07/2015 04:49 AM, Stefan Hajnoczi wrote: > On Mon, Jul 06, 2015 at 05:49:52PM -0400, John Snow wrote: >> The initial register device-to-host FIS no longer needs to specially >> set certain fields, as these can be handled generically by setting those >> fields explicitly with the signatures

Re: [Qemu-devel] [PATCH 2/2] ahci: fix signature generation

2015-07-07 Thread Stefan Hajnoczi
On Mon, Jul 06, 2015 at 05:49:52PM -0400, John Snow wrote: > The initial register device-to-host FIS no longer needs to specially > set certain fields, as these can be handled generically by setting those > fields explicitly with the signatures we want at port reset time. > > (1) Signatures are de

[Qemu-devel] [PATCH 2/2] ahci: fix signature generation

2015-07-06 Thread John Snow
The initial register device-to-host FIS no longer needs to specially set certain fields, as these can be handled generically by setting those fields explicitly with the signatures we want at port reset time. (1) Signatures are decomposed into their four component registers and set upon (AHCI)