Re: [Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

2017-11-17 Thread Darren Kenny
On Fri, Nov 17, 2017 at 04:03:28PM +0100, Gerd Hoffmann wrote: Hi, OK, so the odd thing then is the check for !remote_display earlier on in the function (missing from the quote above) which seems to end up initializing VNC (albeit with localhost) when CONFIG_VNC is defined, but no other local

Re: [Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

2017-11-17 Thread Gerd Hoffmann
Hi, > OK, so the odd thing then is the check for !remote_display earlier > on in the function (missing from the quote above) which seems to end > up initializing VNC (albeit with localhost) when CONFIG_VNC is > defined, but no other local display type has been selected. remote_display is set in

Re: [Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

2017-11-17 Thread Darren Kenny
Hi Gerd, Thanks for clarifying things for me. On Fri, Nov 17, 2017 at 02:24:54PM +0100, Gerd Hoffmann wrote: Hi, > -dpy.type = DISPLAY_TYPE_NONE; > +if (!qemu_display_find_default(&dpy)) { > +dpy.type = DISPLAY_TYPE_NONE; > +#if defined(CONFIG_VNC) > +

Re: [Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

2017-11-17 Thread Gerd Hoffmann
Hi, > > -dpy.type = DISPLAY_TYPE_NONE; > > +if (!qemu_display_find_default(&dpy)) { > > +dpy.type = DISPLAY_TYPE_NONE; > > +#if defined(CONFIG_VNC) > > +vnc_parse("localhost:0,to=99,id=default", &error_abort); > > #endif > > Mostly some questions on this:

Re: [Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

2017-11-17 Thread Darren Kenny
On Fri, Nov 17, 2017 at 11:30:41AM +0100, Gerd Hoffmann wrote: Using the new registry instead of #ifdefs in vl.c. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 + ui/console.c | 19 +++ vl.c | 15 +-- 3 files changed, 25 insertions(+

[Qemu-devel] [PATCH 19/24] console: add and use qemu_display_find_default

2017-11-17 Thread Gerd Hoffmann
Using the new registry instead of #ifdefs in vl.c. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 + ui/console.c | 19 +++ vl.c | 15 +-- 3 files changed, 25 insertions(+), 10 deletions(-) diff --git a/include/ui/console.h b/inclu