Re: [Qemu-devel] [PATCH 19/21] pci: Don't call pci_irq_handler() for a negative intx

2017-04-11 Thread Cédric Le Goater
On 04/10/2017 07:59 AM, David Gibson wrote: > On Wed, Apr 05, 2017 at 02:41:44PM +0200, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> Under some circumstances, pci_intx() can return -1 (when the interrupt >> pin in the config space is 0 which normally means no interrupt). >> >> I h

Re: [Qemu-devel] [PATCH 19/21] pci: Don't call pci_irq_handler() for a negative intx

2017-04-09 Thread David Gibson
On Wed, Apr 05, 2017 at 02:41:44PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Under some circumstances, pci_intx() can return -1 (when the interrupt > pin in the config space is 0 which normally means no interrupt). > > I have seen cases of pci_set_irq() being called on su

[Qemu-devel] [PATCH 19/21] pci: Don't call pci_irq_handler() for a negative intx

2017-04-05 Thread Cédric Le Goater
From: Benjamin Herrenschmidt Under some circumstances, pci_intx() can return -1 (when the interrupt pin in the config space is 0 which normally means no interrupt). I have seen cases of pci_set_irq() being called on such devices, in turn causing pci_irq_handler() to be called with "-1" as an arg