Paolo Bonzini wrote:
> On 18/04/2017 11:44, Paolo Bonzini wrote:
>>
>>
>> On 17/04/2017 22:00, Juan Quintela wrote:
>>> load_vmstate() already use error_report, so be consistent.
>>
>> Better: make both return Error* via an Error** parameter, and add
>>
>> hmp_handle_error(mon, &err);
>>
"Dr. David Alan Gilbert" wrote:
> https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg03927.html
Damn thing. And I did it by hand (not that it was very difficult).
Added bonus is that I have already changed load_vmstate on the same
patch.
Will post them on next respin.
Later, Juan.
* Juan Quintela (quint...@redhat.com) wrote:
> load_vmstate() already use error_report, so be consistent.
>
> Signed-off-by: Juan Quintela
See https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg03927.html
Dave
> ---
> include/sysemu/sysemu.h | 2 +-
> migration/savevm.c | 16
Paolo Bonzini wrote:
> On 18/04/2017 11:44, Paolo Bonzini wrote:
>>
>>
>> On 17/04/2017 22:00, Juan Quintela wrote:
>>> load_vmstate() already use error_report, so be consistent.
>>
>> Better: make both return Error* via an Error** parameter, and add
>>
>> hmp_handle_error(mon, &err);
>>
On 18/04/2017 11:44, Paolo Bonzini wrote:
>
>
> On 17/04/2017 22:00, Juan Quintela wrote:
>> load_vmstate() already use error_report, so be consistent.
>
> Better: make both return Error* via an Error** parameter, and add
>
> hmp_handle_error(mon, &err);
>
> to hmp_savevm and error_repor
On 17/04/2017 22:00, Juan Quintela wrote:
> load_vmstate() already use error_report, so be consistent.
Better: make both return Error* via an Error** parameter, and add
hmp_handle_error(mon, &err);
to hmp_savevm and error_report_err(err) on the loading side.
Paolo
> Signed-off-by: Juan Q
load_vmstate() already use error_report, so be consistent.
Signed-off-by: Juan Quintela
---
include/sysemu/sysemu.h | 2 +-
migration/savevm.c | 16
monitor.c| 2 +-
replay/replay-snapshot.c | 2 +-
4 files changed, 11 insertions(+), 11 deletions(-)
di
