Re: [Qemu-devel] [PATCH 18/39] ide: convert to memory API

2011-08-02 Thread Avi Kivity
On 08/01/2011 10:22 PM, Richard Henderson wrote: On 07/31/2011 10:57 AM, Avi Kivity wrote: > +pci_register_bar_region(dev, 3, PCI_BASE_ADDRESS_SPACE_IO, > +&d->cmd646_bar[2].cmd); Typo: cmd646_bar[1]. Thanks, fixed. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH 18/39] ide: convert to memory API

2011-08-01 Thread Richard Henderson
On 07/31/2011 10:57 AM, Avi Kivity wrote: > +pci_register_bar_region(dev, 3, PCI_BASE_ADDRESS_SPACE_IO, > +&d->cmd646_bar[2].cmd); Typo: cmd646_bar[1]. r~

[Qemu-devel] [PATCH 18/39] ide: convert to memory API

2011-07-31 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/ide/cmd646.c | 208 +++ hw/ide/pci.c| 25 --- hw/ide/pci.h| 19 - hw/ide/piix.c | 64 + hw/ide/via.c| 65 + 5 files changed, 261 insertions(+), 120 d