Best to use the same type, to avoid unwanted truncation or sign
extension.
BlockConf can't use plain int for cyls, heads and secs, because
integer properties require an exact width.
Signed-off-by: Markus Armbruster
---
hw/block-common.h |2 +-
hw/hd-geometry.c |4 ++--
hw/ide/core.c
On Wed, Jul 4, 2012 at 4:36 PM, Eric Blake wrote:
> On 07/04/2012 10:19 AM, Paolo Bonzini wrote:
>> Il 03/07/2012 22:15, Andreas Färber ha scritto:
>
> I'd also vote for %u. PRI*32 do not seem very useful compared to plain
> int versions.
>>> If it's not useful we should use unsigned i
On Tue, Jul 3, 2012 at 8:15 PM, Andreas Färber wrote:
> Am 03.07.2012 21:11, schrieb Blue Swirl:
>> On Mon, Jul 2, 2012 at 2:34 PM, Stefan Hajnoczi wrote:
>>> On Mon, Jul 2, 2012 at 3:15 PM, Markus Armbruster wrote:
Andreas Färber writes:
> Am 02.07.2012 14:55, schrieb Stefan Hajn
On 07/04/2012 10:19 AM, Paolo Bonzini wrote:
> Il 03/07/2012 22:15, Andreas Färber ha scritto:
I'd also vote for %u. PRI*32 do not seem very useful compared to plain
int versions.
>> If it's not useful we should use unsigned int.
>
> It just means that we're assuming 32-bit ints, wh
Il 03/07/2012 22:15, Andreas Färber ha scritto:
>> >
>> > I'd also vote for %u. PRI*32 do not seem very useful compared to plain
>> > int versions.
> If it's not useful we should use unsigned int.
It just means that we're assuming 32-bit ints, which is a fact. The day
an IL32 platform appears th
Am 03.07.2012 21:11, schrieb Blue Swirl:
> On Mon, Jul 2, 2012 at 2:34 PM, Stefan Hajnoczi wrote:
>> On Mon, Jul 2, 2012 at 3:15 PM, Markus Armbruster wrote:
>>> Andreas Färber writes:
>>>
Am 02.07.2012 14:55, schrieb Stefan Hajnoczi:
> On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus A
On Mon, Jul 2, 2012 at 2:34 PM, Stefan Hajnoczi wrote:
> On Mon, Jul 2, 2012 at 3:15 PM, Markus Armbruster wrote:
>> Andreas Färber writes:
>>
>>> Am 02.07.2012 14:55, schrieb Stefan Hajnoczi:
On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote:
> Best to use the same type
On Mon, Jul 2, 2012 at 3:15 PM, Markus Armbruster wrote:
> Andreas Färber writes:
>
>> Am 02.07.2012 14:55, schrieb Stefan Hajnoczi:
>>> On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote:
Best to use the same type, to avoid unwanted truncation or sign
extension.
>>>
Andreas Färber writes:
> Am 02.07.2012 14:55, schrieb Stefan Hajnoczi:
>> On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote:
>>> Best to use the same type, to avoid unwanted truncation or sign
>>> extension.
>>>
>>> BlockConf can't use plain int for cyls, heads and secs, because
>
Am 02.07.2012 14:55, schrieb Stefan Hajnoczi:
> On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote:
>> Best to use the same type, to avoid unwanted truncation or sign
>> extension.
>>
>> BlockConf can't use plain int for cyls, heads and secs, because
>> integer properties require an
On Fri, Jun 29, 2012 at 05:34:40PM +0200, Markus Armbruster wrote:
> Best to use the same type, to avoid unwanted truncation or sign
> extension.
>
> BlockConf can't use plain int for cyls, heads and secs, because
> integer properties require an exact width.
>
> Signed-off-by: Markus Armbruster
On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
> Best to use the same type, to avoid unwanted truncation or sign
> extension.
Awesome patch! :-)
>
> BlockConf can't use plain int for cyls, heads and secs, because
> integer properties require an exact width.
>
> Signed-off-by: Markus A
Best to use the same type, to avoid unwanted truncation or sign
extension.
BlockConf can't use plain int for cyls, heads and secs, because
integer properties require an exact width.
Signed-off-by: Markus Armbruster
---
blockdev.h |2 +-
hw/hd-geometry.c |4 ++--
hw/ide/core.c|
13 matches
Mail list logo
