Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-24 Thread Erik Rull
Hi Gerd, could you provide a single patch file for the new USB files against the released qemu 0.14.0 or 0.14.1? I tried to create that file by assembling the patch emails but no real success. Feedback on the patch is guaranteed :-) Thanks a lot! Best regards, Erik

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-21 Thread Andreas Färber
Am 17.05.2011 um 22:39 schrieb Blue Swirl: On Tue, May 17, 2011 at 5:47 AM, David Ahern wrote: On 05/16/11 13:56, Gerd Hoffmann wrote: This patch finally merges the EHCI host adapter aka USB 2.0 support. Based on git://git.kiszka.org/qemu.git ehci Changes: - Adapt to recent changes in th

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread David Ahern
On 05/17/11 14:39, Blue Swirl wrote: > The development history (implement a feature, fix bugs, implement > another, fix bugs etc) is not interesting and pulling it would make > bisection and other bugfixing more difficult. The patches should not > add known broken features and fix them next. > >

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread Blue Swirl
On Tue, May 17, 2011 at 5:47 AM, David Ahern wrote: > > > On 05/16/11 13:56, Gerd Hoffmann wrote: >> This patch finally merges the EHCI host adapter aka USB 2.0 support. >> >> Based on git://git.kiszka.org/qemu.git ehci >> >> Changes: >>   - Adapt to recent changes in the usb subsystem. >>   - Don

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread Hans de Goede
Hi, On 05/17/2011 07:05 PM, David Ahern wrote: On 05/17/11 09:02, Gerd Hoffmann wrote: Hi, (And by the way, where are the focused patches for each, especially the last one - nuking the 8kHz code? It's squashed in, like everything else. We know that it worked on linux and that printe

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread Hans de Goede
Hi, On 05/17/2011 05:02 PM, Gerd Hoffmann wrote: Hi, (And by the way, where are the focused patches for each, especially the last one - nuking the 8kHz code? It's squashed in, like everything else. We know that it worked on linux and that printers, scanners and storage devices worked ok (m

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread Erik Rull
David Ahern wrote: Come on Gerd. That was not an attempt to get it included. Someone asked for a patch and I took the existing tree, merged with latest and through out the patch. The v1/v2 is not in Jan's tree. That's a hack I have locally to have mixed devices. What is shows is that is not a big

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread David Ahern
On 05/17/11 01:20, Gerd Hoffmann wrote: >> On 05/16/11 13:56, Gerd Hoffmann wrote: >>> This patch finally merges the EHCI host adapter aka USB 2.0 support. >>> >>> Based on git://git.kiszka.org/qemu.git ehci >>> >>> Changes: >>>- Adapt to recent changes in the usb subsystem. >>>- Don't cr

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread David Ahern
On 05/17/11 09:02, Gerd Hoffmann wrote: > > Hi, > >> (And by the way, where are the focused patches for each, especially the >> last one - nuking the 8kHz code? > > It's squashed in, like everything else. > >> We know that it worked on linux and >> that printers, scanners and storage device

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread Gerd Hoffmann
Hi, (And by the way, where are the focused patches for each, especially the last one - nuking the 8kHz code? It's squashed in, like everything else. We know that it worked on linux and that printers, scanners and storage devices worked ok (mostly). 8 kHz is insane. I looked closely whil

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread Gerd Hoffmann
Hi, Right, you did not even try to work with Jan's tree. There is no reason the EHCI code could not have been brought in to qemu that way. The usual way to review & merge code is to send a patch series against recent master to qemu-devel, optionally with a git tree to pull from. So I tried

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread David Ahern
On 05/17/11 07:46, Gerd Hoffmann wrote: > > Hi, > As someone who spent a significant amount of time working on the EHCI code last year I am absolutely not ok with this. The entire contribution history for EHCI lost - and for no reason. >>> >>> There is a reason. I've trie

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread David Ahern
On 05/17/11 06:42, David Ahern wrote: > > > On 05/17/11 01:20, Gerd Hoffmann wrote: >>> On 05/16/11 13:56, Gerd Hoffmann wrote: This patch finally merges the EHCI host adapter aka USB 2.0 support. Based on git://git.kiszka.org/qemu.git ehci Changes: - Adapt to r

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread Gerd Hoffmann
Hi, As someone who spent a significant amount of time working on the EHCI code last year I am absolutely not ok with this. The entire contribution history for EHCI lost - and for no reason. There is a reason. I've tried to keep the history, but it was a big mess with conflicts and build err

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread David Ahern
On 05/17/11 01:20, Gerd Hoffmann wrote: >> On 05/16/11 13:56, Gerd Hoffmann wrote: >>> This patch finally merges the EHCI host adapter aka USB 2.0 support. >>> >>> Based on git://git.kiszka.org/qemu.git ehci >>> >>> Changes: >>>- Adapt to recent changes in the usb subsystem. >>>- Don't cr

Re: [Qemu-devel] [PATCH 18/18] usb: add ehci adapter

2011-05-17 Thread Gerd Hoffmann
On 05/16/11 13:56, Gerd Hoffmann wrote: This patch finally merges the EHCI host adapter aka USB 2.0 support. Based on git://git.kiszka.org/qemu.git ehci Changes: - Adapt to recent changes in the usb subsystem. - Don't create device automagically, use -device instead. - Add quickstart t