Re: [Qemu-devel] [PATCH 17/37] target-ppc: Introduce DFP Add

2014-04-18 Thread Tom Musta
On 4/18/2014 2:10 PM, Richard Henderson wrote: > On 04/18/2014 07:50 AM, Tom Musta wrote: [...] > > The forms seem equally readable to me, with the advantage that we'll get good > branch prediction on direct subroutine calls. And if the compiler decides > that > inlining is profitable, it'll hav

Re: [Qemu-devel] [PATCH 17/37] target-ppc: Introduce DFP Add

2014-04-18 Thread Richard Henderson
On 04/18/2014 07:50 AM, Tom Musta wrote: > +__attribute__ ((unused)) > +static void dfp_run_post_processors(struct PPC_DFP *dfp, > +PPC_DFP_PostProc post_processors[], const size_t n) > +{ > +int i; > + > +for (i = 0; i < n; i++) { > +post_processors[i](dfp); > +

Re: [Qemu-devel] [PATCH 17/37] target-ppc: Introduce DFP Add

2014-04-18 Thread Richard Henderson
On 04/18/2014 07:50 AM, Tom Musta wrote: > +PPC_DFP_PostProc ADD_PPs[] = { static const. r~

[Qemu-devel] [PATCH 17/37] target-ppc: Introduce DFP Add

2014-04-18 Thread Tom Musta
Add emulation of the PowerPC Decimal Floating Point Add instructions dadd[q][.] Various GCC unused annotations are removed since it is now safe to remove them. Signed-off-by: Tom Musta --- target-ppc/dfp_helper.c | 129 +-- target-ppc/helper.h |