Re: [Qemu-devel] [PATCH 17/28] ahci: construct PIO Setup FIS for PIO commands

2014-07-31 Thread Stefan Hajnoczi
On Mon, Jul 07, 2014 at 02:17:58PM -0400, John Snow wrote: > +static void ahci_write_fis_pio(AHCIDevice *ad, uint16_t len) > +{ > +AHCIPortRegs *pr = &ad->port_regs; > +uint8_t *pio_fis, *cmd_fis; > +uint64_t tbl_addr; > +dma_addr_t cmd_len = 0x80; > + > +if (!ad->res_fis || !(p

[Qemu-devel] [PATCH 17/28] ahci: construct PIO Setup FIS for PIO commands

2014-07-07 Thread John Snow
From: Paolo Bonzini PIO commands should put a PIO Setup FIS in the receive area when data transfer ends. Currently QEMU does not do this and only places the D2H FIS at the end of the operation. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow --- hw/ide/ahci.c | 55 +