Re: [Qemu-devel] [PATCH 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f()

2016-03-29 Thread Kevin Wolf
Am 26.03.2016 um 22:05 hat Max Reitz geschrieben: > On 18.03.2016 19:21, Kevin Wolf wrote: > > We must forbid changing the WCE flag in bdrv_reopen() in the same patch, > > as otherwise the behaviour would change so that the flag takes > > precedence over the explicitly specified option. > > > > Th

Re: [Qemu-devel] [PATCH 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f()

2016-03-26 Thread Max Reitz
On 18.03.2016 19:21, Kevin Wolf wrote: > We must forbid changing the WCE flag in bdrv_reopen() in the same patch, > as otherwise the behaviour would change so that the flag takes > precedence over the explicitly specified option. > > The correct value of the WCE flag depends on the BlockBackend us

[Qemu-devel] [PATCH 17/20] qemu-io: Use bdrv_parse_cache_mode() in reopen_f()

2016-03-20 Thread Kevin Wolf
We must forbid changing the WCE flag in bdrv_reopen() in the same patch, as otherwise the behaviour would change so that the flag takes precedence over the explicitly specified option. The correct value of the WCE flag depends on the BlockBackend user (e.g. guest device) and isn't a decision that