Re: [Qemu-devel] [PATCH 17/17] include: Move fprintf_function to disas/

2019-04-12 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> The previous commits have eliminated fprintf_function outside >> disassemblers, simplifying code and cleaning up the ugly type-punning >> fprintf_function seems to attract. Move fprintf_function to >> include/di

Re: [Qemu-devel] [PATCH 17/17] include: Move fprintf_function to disas/

2019-04-12 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > The previous commits have eliminated fprintf_function outside > disassemblers, simplifying code and cleaning up the ugly type-punning > fprintf_function seems to attract. Move fprintf_function to > include/disas/dis-asm.h to reduce the temptation to

[Qemu-devel] [PATCH 17/17] include: Move fprintf_function to disas/

2019-04-11 Thread Markus Armbruster
The previous commits have eliminated fprintf_function outside disassemblers, simplifying code and cleaning up the ugly type-punning fprintf_function seems to attract. Move fprintf_function to include/disas/dis-asm.h to reduce the temptation to abuse it. I considered renaming it to fprintf_ftype (