Re: [Qemu-devel] [PATCH 16/35] tcg-s390: Re-implement tcg_out_movi.

2010-06-13 Thread Richard Henderson
On 06/12/2010 05:04 AM, Aurelien Jarno wrote: >> +for (i = 0; i < 4; i++) { >> +tcg_target_long mask = 0xull << i*16; >> +if ((uval & mask) != 0 && (uval & ~mask) == 0) { > > Wouldn't it be simpler to use (uval & mask) == uval ? Doh. >> +/* Try for PC-relative address

Re: [Qemu-devel] [PATCH 16/35] tcg-s390: Re-implement tcg_out_movi.

2010-06-13 Thread Aurelien Jarno
On Fri, Jun 04, 2010 at 12:14:24PM -0700, Richard Henderson wrote: > Make better use of the LOAD HALFWORD IMMEDIATE, LOAD IMMEDIATE, > and INSERT IMMEDIATE instruction groups. > > Signed-off-by: Richard Henderson > --- > tcg/s390/tcg-target.c | 129 > +++

[Qemu-devel] [PATCH 16/35] tcg-s390: Re-implement tcg_out_movi.

2010-06-04 Thread Richard Henderson
Make better use of the LOAD HALFWORD IMMEDIATE, LOAD IMMEDIATE, and INSERT IMMEDIATE instruction groups. Signed-off-by: Richard Henderson --- tcg/s390/tcg-target.c | 129 +++-- 1 files changed, 113 insertions(+), 16 deletions(-) diff --git a/tcg/s390