Re: [Qemu-devel] [PATCH 15/23] migration: use global variable directly

2011-10-04 Thread Juan Quintela
Anthony Liguori wrote: > How about we compromise and add a: > > MigrationState *migrate_get_current(void); I can agree with this one. > I'm strongly opposed to propagating direct usage of a global. If it's > at least a function call, that's a bit nicer. What I am against is with trying to "hi

Re: [Qemu-devel] [PATCH 15/23] migration: use global variable directly

2011-10-04 Thread Anthony Liguori
On 09/23/2011 07:57 AM, Juan Quintela wrote: We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->file test because it is already done inside qemu_file_set_rate_limit() function. Signed-off-by: Juan Quintela --- migration.c

[Qemu-devel] [PATCH 15/23] migration: use global variable directly

2011-09-23 Thread Juan Quintela
We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->file test because it is already done inside qemu_file_set_rate_limit() function. Signed-off-by: Juan Quintela --- migration.c |6 ++ 1 files changed, 2 insertions(+)

[Qemu-devel] [PATCH 15/23] migration: use global variable directly

2011-09-20 Thread Juan Quintela
We are setting a pointer to a local variable in the previous line, just use the global variable directly. We remove the ->file test because it is already done inside qemu_file_set_rate_limit() function. Signed-off-by: Juan Quintela --- migration.c |6 ++ 1 files changed, 2 insertions(+)