Re: [Qemu-devel] [PATCH 15/22] usb: Add packet combining functions

2012-10-30 Thread Hans de Goede
Hi, On 10/30/2012 02:23 PM, Hans de Goede wrote: Hi, On 10/25/2012 08:55 AM, Gerd Hoffmann wrote: On 10/24/12 18:14, Hans de Goede wrote: +/* + * Process / cancel combined packets, called from + * usb_ep_combine_input_packets() / usb_combined_packet_cancel(). + * Only called f

Re: [Qemu-devel] [PATCH 15/22] usb: Add packet combining functions

2012-10-30 Thread Hans de Goede
Hi, On 10/30/2012 02:23 PM, Hans de Goede wrote: Hi, On 10/25/2012 08:55 AM, Gerd Hoffmann wrote: On 10/24/12 18:14, Hans de Goede wrote: +/* + * Process / cancel combined packets, called from + * usb_ep_combine_input_packets() / usb_combined_packet_cancel(). + * Only called f

Re: [Qemu-devel] [PATCH 15/22] usb: Add packet combining functions

2012-10-30 Thread Hans de Goede
Hi, On 10/25/2012 08:55 AM, Gerd Hoffmann wrote: On 10/24/12 18:14, Hans de Goede wrote: +/* + * Process / cancel combined packets, called from + * usb_ep_combine_input_packets() / usb_combined_packet_cancel(). + * Only called for devices which call these functions themselves. +

Re: [Qemu-devel] [PATCH 15/22] usb: Add packet combining functions

2012-10-24 Thread Gerd Hoffmann
On 10/24/12 18:14, Hans de Goede wrote: > +/* > + * Process / cancel combined packets, called from > + * usb_ep_combine_input_packets() / usb_combined_packet_cancel(). > + * Only called for devices which call these functions themselves. > + */ > +int (*handle_combined_data)(

[Qemu-devel] [PATCH 15/22] usb: Add packet combining functions

2012-10-24 Thread Hans de Goede
Currently we only do pipelining for output endpoints, since to properly support short-not-ok semantics we can only have one outstanding input packet. Since the ehci and uhci controllers have a limited per td packet size guests will split large input transfers to into multiple packets, and since we