perror() is defined to fprintf(stderr,...). HACKING says
fprintf(stderr,...) is wrong. So perror() is too.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
CC: Alistair Francis
Reviewed-by: Philippe Mathieu-Daudé
---
v7: New pat
Philippe Mathieu-Daudé writes:
> On 04/19/2018 01:45 PM, Ian Jackson wrote:
>> perror() is defined to fprintf(stderr,...). HACKING says
>> fprintf(stderr,...) is wrong. So perror() is too.
>>
>> Signed-off-by: Ian Jackson
>> CC: Paolo Bonzini
>> CC: Markus Armbruster
>> CC: Daniel P. Berran
On Tue, Apr 24, 2018 at 10:43:09AM -0500, Eric Blake wrote:
> On 04/24/2018 10:40 AM, Eric Blake wrote:
> > On 04/24/2018 10:18 AM, Daniel P. Berrangé wrote:
> >
> >>> - static void vreport(report_type type, const char *fmt, va_list ap)
> >>> + static void vreport(report_type type, int errnoval,
On 04/24/2018 10:40 AM, Eric Blake wrote:
> On 04/24/2018 10:18 AM, Daniel P. Berrangé wrote:
>
>>> - static void vreport(report_type type, const char *fmt, va_list ap)
>>> + static void vreport(report_type type, int errnoval, const char *fmt,
>>> va_list ap)
>>> ...
>>> + if (errnoval >=
On 04/24/2018 10:18 AM, Daniel P. Berrangé wrote:
>> - static void vreport(report_type type, const char *fmt, va_list ap)
>> + static void vreport(report_type type, int errnoval, const char *fmt,
>> va_list ap)
>> ...
>> + if (errnoval >= 0) {
>> + error_printf(": %s", strerror(er
On Tue, Apr 24, 2018 at 03:53:48PM +0100, Ian Jackson wrote:
> Philippe Mathieu-Daudé writes ("Re: [Qemu-devel] [PATCH 15/16] os-posix:
> cleanup: Replace perror with error_report"):
> > On 04/19/2018 01:45 PM, Ian Jackson wrote:
> > > -perror("mlo
Philippe Mathieu-Daudé writes ("Re: [Qemu-devel] [PATCH 15/16] os-posix:
cleanup: Replace perror with error_report"):
> On 04/19/2018 01:45 PM, Ian Jackson wrote:
> > -perror("mlockall");
> > +error_report("mlockall: %s", strerror(
On 04/19/2018 01:45 PM, Ian Jackson wrote:
> perror() is defined to fprintf(stderr,...). HACKING says
> fprintf(stderr,...) is wrong. So perror() is too.
>
> Signed-off-by: Ian Jackson
> CC: Paolo Bonzini
> CC: Markus Armbruster
> CC: Daniel P. Berrange
> CC: Michael Tokarev
> CC: Alistair
perror() is defined to fprintf(stderr,...). HACKING says
fprintf(stderr,...) is wrong. So perror() is too.
Signed-off-by: Ian Jackson
CC: Paolo Bonzini
CC: Markus Armbruster
CC: Daniel P. Berrange
CC: Michael Tokarev
CC: Alistair Francis
---
v7: New patch
---
os-posix.c | 8
1 fi
