Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Jes Sorensen
On 06/28/10 18:20, Blue Swirl wrote: > On Mon, Jun 28, 2010 at 4:03 PM, Jes Sorensen wrote: >> Yeah, the problem with tying it to CONFIG_LINUX is that older version of >> Linux may not support it. Looking through the list, MAP_POPULATE is >> really an oddball in there though, so maybe it would be

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Blue Swirl
On Mon, Jun 28, 2010 at 4:03 PM, Jes Sorensen wrote: > On 06/28/10 17:42, Blue Swirl wrote: >> On Mon, Jun 28, 2010 at 2:50 PM, Jes Sorensen >> wrote: >>> I figured out what was causing it. qemu-options.def has an >>> #ifdef MAP_POPULATE in it, which isn't being set without sys/mmap.h >>> being

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Jes Sorensen
On 06/28/10 17:42, Blue Swirl wrote: > On Mon, Jun 28, 2010 at 2:50 PM, Jes Sorensen wrote: >> I figured out what was causing it. qemu-options.def has an >> #ifdef MAP_POPULATE in it, which isn't being set without sys/mmap.h >> being included. Pretty much every other #ifdef in qemu-options.def are

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Blue Swirl
On Mon, Jun 28, 2010 at 2:50 PM, Jes Sorensen wrote: > On 06/25/10 19:34, Frank Arnold wrote: >> We are doing KVM testing, so it is Linux. >> >> What I did is putting lines like this somewhere into vl.c and >> os-posix.c: >> fprintf(stderr, "os: QEMU_OPTION_daemonize: %i", QEMU_OPTION_daemonize);

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Jes Sorensen
On 06/25/10 19:34, Frank Arnold wrote: > We are doing KVM testing, so it is Linux. > > What I did is putting lines like this somewhere into vl.c and > os-posix.c: > fprintf(stderr, "os: QEMU_OPTION_daemonize: %i", QEMU_OPTION_daemonize); > fprintf(stderr, "vl: QEMU_OPTION_daemonize: %i", QEMU_OPTI

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Jes Sorensen
On 06/25/10 19:34, Frank Arnold wrote: > We are doing KVM testing, so it is Linux. > > What I did is putting lines like this somewhere into vl.c and > os-posix.c: > fprintf(stderr, "os: QEMU_OPTION_daemonize: %i", QEMU_OPTION_daemonize); > fprintf(stderr, "vl: QEMU_OPTION_daemonize: %i", QEMU_OPTI

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-25 Thread Jes Sorensen
On 06/25/10 18:41, Frank Arnold wrote: > On Thu, 2010-06-10 at 05:42 -0400, jes.soren...@redhat.com wrote: >> diff --git a/os-posix.c b/os-posix.c >> index 6417d16..1672e06 100644 >> --- a/os-posix.c >> +++ b/os-posix.c >> @@ -160,6 +162,9 @@ void os_parse_cmd_args(int index, const char *optarg) >>

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-25 Thread Frank Arnold
On Fri, 2010-06-25 at 19:34 +0200, Frank Arnold wrote: > On Fri, 2010-06-25 at 13:02 -0400, Jes Sorensen wrote: > > On 06/25/10 18:41, Frank Arnold wrote: > > > On Thu, 2010-06-10 at 05:42 -0400, jes.soren...@redhat.com wrote: > > >> diff --git a/os-posix.c b/os-posix.c > > >> index 6417d16..1672e0

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-25 Thread Frank Arnold
On Thu, 2010-06-10 at 05:42 -0400, jes.soren...@redhat.com wrote: > diff --git a/os-posix.c b/os-posix.c > index 6417d16..1672e06 100644 > --- a/os-posix.c > +++ b/os-posix.c > @@ -160,6 +162,9 @@ void os_parse_cmd_args(int index, const char *optarg) > case QEMU_OPTION_chroot: > chroo

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-25 Thread Frank Arnold
On Fri, 2010-06-25 at 13:02 -0400, Jes Sorensen wrote: > On 06/25/10 18:41, Frank Arnold wrote: > > On Thu, 2010-06-10 at 05:42 -0400, jes.soren...@redhat.com wrote: > >> diff --git a/os-posix.c b/os-posix.c > >> index 6417d16..1672e06 100644 > >> --- a/os-posix.c > >> +++ b/os-posix.c > >> @@ -160

[Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-10 Thread Jes . Sorensen
From: Jes Sorensen Move daemonize handling from vl.c to OS specific files. Provide dummy stubs for Win32. Signed-off-by: Jes Sorensen Acked-by: Juan Quintela Acked-by: Richard Henderson --- os-posix.c | 102 os-win32.c |5 ++

[Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Move daemonize handling from vl.c to OS specific files. Provide dummy stubs for Win32. Signed-off-by: Jes Sorensen --- os-posix.c | 102 os-win32.c |5 +++ qemu-os-posix.h |2 + qemu-os-win32.h |2 +

[Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-04 Thread Jes . Sorensen
From: Jes Sorensen Move daemonize handling from vl.c to OS specific files. Provide dummy stubs for Win32. Signed-off-by: Jes Sorensen --- os-posix.c | 102 os-win32.c |5 +++ qemu-os-posix.h |2 + qemu-os-win32.h |2 +